Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 1 | <?xml version="1.0"?> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 2 | <!DOCTYPE module PUBLIC |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 3 | "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" |
| 4 | "https://checkstyle.org/dtds/configuration_1_3.dtd"> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 5 | |
| 6 | <!-- |
| 7 | |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 8 | Checkstyle configuration that checks the sun coding conventions from: |
| 9 | |
| 10 | - the Java Language Specification at |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 11 | https://docs.oracle.com/javase/specs/jls/se11/html/index.html |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 12 | |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 13 | - the Sun Code Conventions at https://www.oracle.com/java/technologies/javase/codeconventions-contents.html |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 14 | |
| 15 | - the Javadoc guidelines at |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 16 | https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 17 | |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 18 | - the JDK Api documentation https://docs.oracle.com/en/java/javase/11/ |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 19 | |
| 20 | - some best practices |
| 21 | |
| 22 | Checkstyle is very configurable. Be sure to read the documentation at |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 23 | https://checkstyle.org (or in your downloaded distribution). |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 24 | |
| 25 | Most Checks are configurable, be sure to consult the documentation. |
| 26 | |
| 27 | To completely disable a check, just comment it out or delete it from the file. |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 28 | To suppress certain violations please review suppression filters. |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 29 | |
| 30 | Finally, it is worth reading the documentation. |
| 31 | |
| 32 | --> |
| 33 | |
| 34 | <module name="Checker"> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 35 | <!-- |
| 36 | If you set the basedir property below, then all reported file |
| 37 | names will be relative to the specified directory. See |
| 38 | https://checkstyle.org/config.html#Checker |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 39 | |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 40 | <property name="basedir" value="${basedir}"/> |
| 41 | --> |
| 42 | <property name="severity" value="error"/> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 43 | |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 44 | <property name="fileExtensions" value="java, properties, xml"/> |
| 45 | |
| 46 | <!-- Excludes all 'module-info.java' files --> |
| 47 | <!-- See https://checkstyle.org/config_filefilters.html --> |
| 48 | <module name="BeforeExecutionExclusionFileFilter"> |
| 49 | <property name="fileNamePattern" value="module\-info\.java$"/> |
| 50 | </module> |
| 51 | |
| 52 | <!-- https://checkstyle.org/config_filters.html#SuppressionFilter --> |
| 53 | <module name="SuppressionFilter"> |
| 54 | <property name="file" value="${org.checkstyle.sun.suppressionfilter.config}" |
| 55 | default="checkstyle-suppressions.xml" /> |
| 56 | <property name="optional" value="true"/> |
| 57 | </module> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 58 | |
| 59 | <!-- Checks that a package-info.java file exists for each package. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 60 | <!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage --> |
| 61 | <!-- <module name="JavadocPackage"/> --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 62 | |
| 63 | <!-- Checks whether files end with a new line. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 64 | <!-- See https://checkstyle.org/config_misc.html#NewlineAtEndOfFile --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 65 | <module name="NewlineAtEndOfFile"/> |
| 66 | |
| 67 | <!-- Checks that property files contain the same keys. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 68 | <!-- See https://checkstyle.org/config_misc.html#Translation --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 69 | <module name="Translation"/> |
| 70 | |
| 71 | <!-- Checks for Size Violations. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 72 | <!-- See https://checkstyle.org/config_sizes.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 73 | <module name="FileLength"/> |
| 74 | |
| 75 | <!-- Checks for whitespace --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 76 | <!-- See https://checkstyle.org/config_whitespace.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 77 | <module name="FileTabCharacter"/> |
| 78 | |
| 79 | <!-- Miscellaneous other checks. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 80 | <!-- See https://checkstyle.org/config_misc.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 81 | <module name="RegexpSingleline"> |
| 82 | <property name="format" value="\s+$"/> |
| 83 | <property name="minimum" value="0"/> |
| 84 | <property name="maximum" value="0"/> |
| 85 | <property name="message" value="Line has trailing spaces."/> |
| 86 | </module> |
| 87 | |
| 88 | <!-- Checks for Headers --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 89 | <!-- See https://checkstyle.org/config_header.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 90 | <!-- <module name="Header"> --> |
| 91 | <!-- <property name="headerFile" value="${checkstyle.header.file}"/> --> |
| 92 | <!-- <property name="fileExtensions" value="java"/> --> |
| 93 | <!-- </module> --> |
| 94 | |
| 95 | <module name="TreeWalker"> |
| 96 | |
| 97 | <!-- Checks for Javadoc comments. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 98 | <!-- See https://checkstyle.org/config_javadoc.html --> |
| 99 | <module name="InvalidJavadocPosition"/> |
| 100 | <module name="JavadocMethod"/> |
| 101 | <module name="JavadocType"/> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 102 | <module name="JavadocVariable"> |
| 103 | <property name="excludeScope" value="private"/> |
| 104 | </module> |
| 105 | <module name="JavadocStyle"/> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 106 | <!-- <module name="MissingJavadocMethod"/> --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 107 | |
| 108 | <!-- Checks for Naming Conventions. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 109 | <!-- See https://checkstyle.org/config_naming.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 110 | <module name="ConstantName"/> |
| 111 | <module name="LocalFinalVariableName"/> |
| 112 | <module name="LocalVariableName"/> |
| 113 | <module name="MemberName"/> |
| 114 | <module name="MethodName"/> |
| 115 | <module name="PackageName"/> |
| 116 | <module name="ParameterName"/> |
| 117 | <module name="StaticVariableName"/> |
| 118 | <module name="TypeName"/> |
| 119 | |
| 120 | <!-- Checks for imports --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 121 | <!-- See https://checkstyle.org/config_imports.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 122 | <module name="AvoidStarImport"/> |
| 123 | <module name="IllegalImport"/> <!-- defaults to sun.* packages --> |
| 124 | <module name="RedundantImport"/> |
| 125 | <module name="UnusedImports"> |
| 126 | <property name="processJavadoc" value="false"/> |
| 127 | </module> |
| 128 | |
| 129 | <!-- Checks for Size Violations. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 130 | <!-- See https://checkstyle.org/config_sizes.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 131 | <module name="LineLength"> |
| 132 | <property name="max" value="120"/> |
| 133 | </module> |
| 134 | <module name="MethodLength"/> |
| 135 | <module name="ParameterNumber"/> |
| 136 | |
| 137 | <!-- Checks for whitespace --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 138 | <!-- See https://checkstyle.org/config_whitespace.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 139 | <module name="EmptyForIteratorPad"/> |
| 140 | <module name="GenericWhitespace"/> |
| 141 | <module name="MethodParamPad"/> |
| 142 | <module name="NoWhitespaceAfter"/> |
| 143 | <module name="NoWhitespaceBefore"/> |
| 144 | <module name="OperatorWrap"> |
| 145 | <property name="option" value="eol"/> |
| 146 | </module> |
| 147 | <module name="ParenPad"/> |
| 148 | <module name="TypecastParenPad"/> |
| 149 | <module name="WhitespaceAfter"/> |
| 150 | <module name="WhitespaceAround"/> |
| 151 | |
| 152 | <!-- Modifier Checks --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 153 | <!-- See https://checkstyle.org/config_modifiers.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 154 | <module name="ModifierOrder"/> |
| 155 | <module name="RedundantModifier"/> |
| 156 | |
| 157 | <!-- Checks for blocks. You know, those {}'s --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 158 | <!-- See https://checkstyle.org/config_blocks.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 159 | <module name="AvoidNestedBlocks"/> |
| 160 | <module name="EmptyBlock"/> |
| 161 | <module name="LeftCurly"/> |
| 162 | <module name="NeedBraces"/> |
| 163 | <module name="RightCurly"/> |
| 164 | |
| 165 | <!-- Checks for common coding problems --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 166 | <!-- See https://checkstyle.org/config_coding.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 167 | <module name="AvoidInlineConditionals"/> |
| 168 | <module name="EmptyStatement"/> |
| 169 | <module name="EqualsHashCode"/> |
| 170 | <!-- <module name="HiddenField"/> --> |
| 171 | <module name="IllegalInstantiation"/> |
| 172 | <module name="InnerAssignment"/> |
| 173 | <module name="MagicNumber"/> |
| 174 | <module name="MissingSwitchDefault"/> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 175 | <module name="MultipleVariableDeclarations"/> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 176 | <module name="SimplifyBooleanExpression"/> |
| 177 | <module name="SimplifyBooleanReturn"/> |
| 178 | |
| 179 | <!-- Checks for class design --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 180 | <!-- See https://checkstyle.org/config_design.html --> |
| 181 | <!-- <module name="DesignForExtension"/> --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 182 | <module name="FinalClass"/> |
| 183 | <module name="HideUtilityClassConstructor"/> |
| 184 | <module name="InterfaceIsType"/> |
| 185 | <module name="VisibilityModifier"> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 186 | <property name="allowPublicFinalFields" value="true"/> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 187 | </module> |
| 188 | |
| 189 | <!-- Miscellaneous other checks. --> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 190 | <!-- See https://checkstyle.org/config_misc.html --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 191 | <module name="ArrayTypeStyle"/> |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 192 | <!-- <module name="FinalParameters"/> --> |
| 193 | <!-- <module name="TodoComment"/> --> |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 194 | <module name="UpperEll"/> |
| 195 | |
Davide Pesavento | 8cda2f9 | 2020-11-01 23:08:09 -0500 | [diff] [blame^] | 196 | <!-- https://checkstyle.org/config_filters.html#SuppressionXpathFilter --> |
| 197 | <module name="SuppressionXpathFilter"> |
| 198 | <property name="file" value="${org.checkstyle.sun.suppressionxpathfilter.config}" |
| 199 | default="checkstyle-xpath-suppressions.xml" /> |
| 200 | <property name="optional" value="true"/> |
| 201 | </module> |
| 202 | |
Alexander Afanasyev | cbc4101 | 2016-02-19 20:10:57 -0800 | [diff] [blame] | 203 | </module> |
| 204 | |
| 205 | </module> |