commit 81203b9189fe65660eeb66c1f9b94c38bf11a71d
author Alexander Afanasyev <aa@cs.fiu.edu> Thu Nov 09 13:53:56 2017 -0500
committer Alexander Afanasyev <aa@cs.fiu.edu> Sat Nov 11 13:45:30 2017 -0500
tree 60e7a91f867528af2534582d7b07a1f292be6b6d
parent 30ab3ff1949d0a761081e7930c71e57096d3984a

Fix bug with config file processing

- tcp_bulk_insert was not properly processed
- make tcp_bulk_insert item optional

Change-Id: I5a98202f24e7e4f7696ed58e93010b1a88145ad9

src/repo.cpp

diff --git a/src/repo.cpp b/src/repo.cpp
index 20f2f07..bb52b45 100644
--- a/src/repo.cpp
+++ b/src/repo.cpp
@@ -48,7 +48,7 @@
   repoConfig.repoConfigPath = configPath;
 
   ptree dataConf = repoConf.get_child("data");
-  for (const auto section : dataConf) {
+  for (const auto& section : dataConf) {
     if (section.first == "prefix")
       repoConfig.dataPrefixes.push_back(Name(section.second.get_value<std::string>()));
     else if (section.first == "registration-subset")
@@ -59,7 +59,7 @@
   }
 
   ptree commandConf = repoConf.get_child("command");
-  for (const auto section : commandConf) {
+  for (const auto& section : commandConf) {
     if (section.first == "prefix")
       repoConfig.repoPrefixes.push_back(Name(section.second.get_value<std::string>()));
     else
@@ -67,26 +67,28 @@
                                         "configuration file '"+ configPath +"'"));
   }
 
-  ptree tcpBulkInsert = repoConf.get_child("tcp_bulk_insert");
+  auto tcpBulkInsert = repoConf.get_child_optional("tcp_bulk_insert");
   bool isTcpBulkEnabled = false;
   std::string host = "localhost";
   std::string port = "7376";
-  for (const auto section : dataConf) {
-    isTcpBulkEnabled = true;
+  if (tcpBulkInsert) {
+    for (const auto& section : *tcpBulkInsert) {
+      isTcpBulkEnabled = true;
 
-    // tcp_bulk_insert {
-    //   host "localhost"  ; IP address or hostname to listen on
-    //   port 7635  ; Port number to listen on
-    // }
-    if (section.first == "host") {
-      host = section.second.get_value<std::string>();
+      // tcp_bulk_insert {
+      //   host "localhost"  ; IP address or hostname to listen on
+      //   port 7635  ; Port number to listen on
+      // }
+      if (section.first == "host") {
+        host = section.second.get_value<std::string>();
+      }
+      else if (section.first == "port") {
+        port = section.second.get_value<std::string>();
+      }
+      else
+        BOOST_THROW_EXCEPTION(Repo::Error("Unrecognized '" + section.first + "' option in 'tcp_bulk_insert' section in "
+                                          "configuration file '"+ configPath +"'"));
     }
-    else if (section.first == "port") {
-      port = section.second.get_value<std::string>();
-    }
-    else
-      BOOST_THROW_EXCEPTION(Repo::Error("Unrecognized '" + section.first + "' option in 'tcp_bulk_insert' section in "
-                                        "configuration file '"+ configPath +"'"));
   }
   if (isTcpBulkEnabled) {
     repoConfig.tcpBulkInsertEndpoints.push_back(std::make_pair(host, port));