commit 9edaf26034db6642ffceb73f336a1c295d9370b1
author Eric Newberry <enewberry@cs.arizona.edu> Thu Jun 07 23:44:57 2018 -0700
committer Alexander Afanasyev <aa@cs.fiu.edu> Fri Jun 08 10:30:30 2018 -0400
tree 6d767a1bf03298adcd41720e5dfa9203217a4430
parent 9003483df0cbaa784b76705265fe7e30d5b7d55b

tests: resolve ASan error in ManagementTool tests

resolve unused lambda capture errors in newer versions of clang

Change-Id: If03c0a8387ddc35f9999dfbdd3ba474e4387b01b

src/daemon/name-server.cpp

diff --git a/src/daemon/name-server.cpp b/src/daemon/name-server.cpp
index cc1c881..3e0c2b6 100644
--- a/src/daemon/name-server.cpp
+++ b/src/daemon/name-server.cpp
@@ -133,7 +133,7 @@
     }
     m_validator.validate(*data,
                          bind(&NameServer::doUpdate, this, interest.shared_from_this(), data),
-                         [this] (const Data& data, const security::v2::ValidationError& msg) {
+                         [] (const Data& data, const security::v2::ValidationError& msg) {
                            NDNS_LOG_WARN("Ignoring update that did not pass the verification. "
                                          << "Check the root certificate");
                          });

tests/unit/clients/iterative-query-controller.cpp

diff --git a/tests/unit/clients/iterative-query-controller.cpp b/tests/unit/clients/iterative-query-controller.cpp
index 65ab32b..3f51baa 100644
--- a/tests/unit/clients/iterative-query-controller.cpp
+++ b/tests/unit/clients/iterative-query-controller.cpp
@@ -91,7 +91,7 @@
       hasDataBack = true;
       BOOST_CHECK(true);
     },
-    [&hasDataBack] (uint32_t errCode, const std::string& errMsg) {
+    [] (uint32_t errCode, const std::string& errMsg) {
       BOOST_CHECK(false);
     },
     consumerFace);

tests/unit/mgmt/management-tool.cpp

diff --git a/tests/unit/mgmt/management-tool.cpp b/tests/unit/mgmt/management-tool.cpp
index 040bf38..e4ce0c5 100644
--- a/tests/unit/mgmt/management-tool.cpp
+++ b/tests/unit/mgmt/management-tool.cpp
@@ -61,9 +61,7 @@
       copyDir(current, destination / current.filename());
     }
     else {
-      // cannot use fs::copy_file, see https://svn.boost.org/trac/boost/ticket/10038
-      // fs::copy works, as it doesn't use problematic private API
-      copy(current, destination / current.filename());
+      copy_file(current, destination / current.filename());
     }
   }
 }