commit f2e6bb5d1af8fa6163c3ea7c1ab19a35789f55a8
author tylerliu <tylersiqi@163.com> Sun Dec 13 13:23:05 2020 -0800
committer tylerliu <tylersiqi@163.com> Sun Dec 13 13:23:05 2020 -0800
tree 43990c33fafa8726a58e5b31295926ef6c81ace0
parent 01efccb23d9a0d85d3e3ace5f121e6c20be8fc2a

code review fix

Change-Id: Ie616543094aaa31d596980ba7a3cef05de4351fc

src/challenge/challenge-module.hpp

diff --git a/src/challenge/challenge-module.hpp b/src/challenge/challenge-module.hpp
index 02e5027..9d7d859 100644
--- a/src/challenge/challenge-module.hpp
+++ b/src/challenge/challenge-module.hpp
@@ -59,7 +59,7 @@
 
   virtual Block
   genChallengeRequestTLV(Status status, const std::string& challengeStatus,
-                         std::multimap<std::string, std::string>&& params) = 0;
+                         const std::multimap<std::string, std::string>& params) = 0;
 
   // helpers
   static std::string
@@ -68,11 +68,11 @@
 protected:
   // used by challenge modules
   std::tuple<ErrorCode, std::string>
-  returnWithError(ca::RequestState& request, ErrorCode errorCode, std::string&& errorInfo);
+  returnWithError(ca::RequestState& request, ErrorCode errorCode, std::string errorInfo);
 
   std::tuple<ErrorCode, std::string>
   returnWithNewChallengeStatus(ca::RequestState& request, const std::string& challengeStatus,
-                               JsonSection&& challengeSecret, size_t remainingTries, time::seconds remainingTime);
+                               JsonSection challengeSecret, size_t remainingTries, time::seconds remainingTime);
 
   std::tuple<ErrorCode, std::string>
   returnWithSuccess(ca::RequestState& request);