commit e78fd4d972d0b34711896086ae5eab848b1f2595
author Tianyuan Yu <tianyuan@cs.ucla.edu> Wed May 25 13:18:06 2022 -0700
committer Tianyuan Yu <tianyuan@cs.ucla.edu> Thu May 26 19:04:05 2022 -0700
tree 10a7cd9c65cf384c5d97728abc5dd030f53a3b98
parent 829aff664105c42408872a9b88536c60acf9660c

ca: set Data FreshnessPeriod in CaModule::issueCertificate()

Change-Id: I42a169f309e1069965b5f91ed8542a868a77c15b

src/ca-module.cpp

diff --git a/src/ca-module.cpp b/src/ca-module.cpp
index ef41efc..be197d6 100644
--- a/src/ca-module.cpp
+++ b/src/ca-module.cpp
@@ -478,12 +478,13 @@
   certName.append("NDNCERT").appendVersion();
   newCert.setName(certName);
   newCert.setContent(requestState.cert.getContent());
+  newCert.setFreshnessPeriod(1_h);
   NDN_LOG_TRACE("cert request content " << requestState.cert);
   SignatureInfo signatureInfo;
   signatureInfo.setValidityPeriod(period);
   ndn::security::SigningInfo signingInfo(ndn::security::SigningInfo::SIGNER_TYPE_ID,
                                          m_config.caProfile.caPrefix, signatureInfo);
-
+  // Note: we should use KeyChain::makeCertificate() in future.
   m_keyChain.sign(newCert, signingInfo);
   NDN_LOG_TRACE("new cert got signed" << newCert);
   return newCert;

tests/unit-tests/ca-module.t.cpp

diff --git a/tests/unit-tests/ca-module.t.cpp b/tests/unit-tests/ca-module.t.cpp
index b0d4955..00a3f58 100644
--- a/tests/unit-tests/ca-module.t.cpp
+++ b/tests/unit-tests/ca-module.t.cpp
@@ -476,6 +476,12 @@
       BOOST_CHECK(state.m_status == Status::SUCCESS);
     }
   });
+  ca.setStatusUpdateCallback([](const RequestState& request) {
+    if (request.status == Status::SUCCESS && request.requestType == RequestType::NEW) {
+      BOOST_REQUIRE_NO_THROW(Certificate{request.cert});
+      BOOST_CHECK(Certificate(request.cert).isValid());
+    }
+  });
 
   face.receive(*newInterest);
   advanceClocks(time::milliseconds(20), 60);