commit d59f2cf0959935bb95c6f8d55db945f666d227bf
author tylerliu <tylersiqi@163.com> Fri Oct 30 00:00:10 2020 -0700
committer tylerliu <tylersiqi@163.com> Fri Oct 30 00:00:10 2020 -0700
tree 5c5d63fe4ed96b24dab2b4f68c04e28ec54172cf
parent c9ada1b850e5ca107802cc7a820f7c83adb7d394

add encoding unit tests

Change-Id: I319a34a760742e6125e6a28c4ddc23fcf2f29cb3

src/detail/probe-encoder.cpp

diff --git a/src/detail/probe-encoder.cpp b/src/detail/probe-encoder.cpp
index 5141ba1..0591501 100644
--- a/src/detail/probe-encoder.cpp
+++ b/src/detail/probe-encoder.cpp
@@ -24,7 +24,7 @@
 namespace ndncert {
 
 Block
-ProbeEncoder::encodeApplicationParameters(std::vector<std::tuple<std::string, std::string>>&& parameters)
+ProbeEncoder::encodeApplicationParameters(const std::vector<std::tuple<std::string, std::string>>& parameters)
 {
   auto content = makeEmptyBlock(ndn::tlv::ApplicationParameters);
   for (size_t i = 0; i < parameters.size(); ++i) {

src/detail/probe-encoder.hpp

diff --git a/src/detail/probe-encoder.hpp b/src/detail/probe-encoder.hpp
index 0a991c3..0db8cb9 100644
--- a/src/detail/probe-encoder.hpp
+++ b/src/detail/probe-encoder.hpp
@@ -31,7 +31,7 @@
 public:
   // For Client use
   static Block
-  encodeApplicationParameters(std::vector<std::tuple<std::string, std::string>>&& parameters);
+  encodeApplicationParameters(const std::vector<std::tuple<std::string, std::string>>& parameters);
 
   static void
   decodeDataContent(const Block& block, std::vector<std::pair<Name, int>>& availableNames,

src/requester.cpp

diff --git a/src/requester.cpp b/src/requester.cpp
index 7b1df5f..774b805 100644
--- a/src/requester.cpp
+++ b/src/requester.cpp
@@ -88,14 +88,14 @@
 }
 
 shared_ptr<Interest>
-Requester::genProbeInterest(const CaProfile& ca, std::vector<std::tuple<std::string, std::string>>&& probeInfo)
+Requester::genProbeInterest(const CaProfile& ca,const std::vector<std::tuple<std::string, std::string>>& probeInfo)
 {
   Name interestName = ca.m_caPrefix;
   interestName.append("CA").append("PROBE");
   auto interest =std::make_shared<Interest>(interestName);
   interest->setMustBeFresh(true);
   interest->setCanBePrefix(false);
-  interest->setApplicationParameters(ProbeEncoder::encodeApplicationParameters(std::move(probeInfo)));
+  interest->setApplicationParameters(ProbeEncoder::encodeApplicationParameters(probeInfo));
   return interest;
 }
 

src/requester.hpp

diff --git a/src/requester.hpp b/src/requester.hpp
index 4e2a1b1..117229c 100644
--- a/src/requester.hpp
+++ b/src/requester.hpp
@@ -84,7 +84,7 @@
    * @return A shared pointer of to the encoded interest, ready to be sent.
    */
   static shared_ptr<Interest>
-  genProbeInterest(const CaProfile& ca, std::vector<std::tuple<std::string, std::string>>&& probeInfo);
+  genProbeInterest(const CaProfile& ca,const std::vector<std::tuple<std::string, std::string>>& probeInfo);
 
   /**
    * @brief Decodes the replied data for PROBE process from the CA.