commit c84c3bafe7ae1635de93651f9503b6bfc7c2d808
author tylerliu <tylersiqi@163.com> Mon Sep 28 18:09:46 2020 -0700
committer tylerliu <tylersiqi@163.com> Mon Sep 28 18:10:28 2020 -0700
tree 2ea6ec40087e090f750e67b21f0bd516b8231362
parent 02ac22c3899a4c48b9ab510c30c29a020939b149

remove IS_SUBNAME_MIN_OFFEST

Change-Id: Id8e14fef1609a7128aab981bdfb5604c77f8586b

src/ca-module.cpp

diff --git a/src/ca-module.cpp b/src/ca-module.cpp
index c9a52c7..5a16ab3 100644
--- a/src/ca-module.cpp
+++ b/src/ca-module.cpp
@@ -39,7 +39,6 @@
 namespace ndn {
 namespace ndncert {
 
-static const int IS_SUBNAME_MIN_OFFSET = 5;
 static const time::seconds DEFAULT_DATA_FRESHNESS_PERIOD = 1_s;
 static const time::seconds REQUEST_VALIDITY_PERIOD_NOT_BEFORE_GRACE_PERIOD = 120_s;
 
@@ -305,9 +304,8 @@
     // verify the self-signed certificate, the request, and the token
     if (!m_config.m_caPrefix.isPrefixOf(clientCert->getName()) // under ca prefix
         || !security::v2::Certificate::isValidName(clientCert->getName()) // is valid cert name
-        || clientCert->getName().size() < m_config.m_caPrefix.size() + IS_SUBNAME_MIN_OFFSET
-        || clientCert->getName().size() >
-                m_config.m_caPrefix.size() + IS_SUBNAME_MIN_OFFSET - 1 + m_config.m_maxSuffixLength) {
+        || clientCert->getIdentity().size() <= m_config.m_caPrefix.size()
+        || clientCert->getIdentity().size() > m_config.m_caPrefix.size() + m_config.m_maxSuffixLength) {
       _LOG_ERROR("Invalid self-signed certificate name " << clientCert->getName());
       return;
     }
@@ -337,9 +335,8 @@
     // verify the certificate
     if (!m_config.m_caPrefix.isPrefixOf(clientCert->getName()) // under ca prefix
         || !security::v2::Certificate::isValidName(clientCert->getName()) // is valid cert name
-        || clientCert->getName().size() < m_config.m_caPrefix.size() + IS_SUBNAME_MIN_OFFSET
-        || clientCert->getName().size() >
-                m_config.m_caPrefix.size() + IS_SUBNAME_MIN_OFFSET - 1 + m_config.m_maxSuffixLength) {
+        || clientCert->getIdentity().size() <= m_config.m_caPrefix.size()
+        || clientCert->getIdentity().size() > m_config.m_caPrefix.size() + m_config.m_maxSuffixLength) {
       _LOG_ERROR("Invalid certificate name " << clientCert->getName());
       return;
     }