commit bdcf52e9b7739a3ca7523f685de5ac1524f9a376
author Junxiao Shi <git@mail1.yoursunny.com> Sun Apr 24 21:49:01 2022 +0000
committer Davide Pesavento <davidepesa@gmail.com> Wed Apr 27 19:11:32 2022 -0400
tree 7ef20111d47feaf90637df94519301cc8445666c
parent cc6889de476c20faa52962f447cb99cbc26c1f6d

tests: refactor ChallengePossession test cases

Change-Id: Ia930d373e981bb0f96e0350bb31b4d3cbb69082f

src/challenge/challenge-possession.cpp

diff --git a/src/challenge/challenge-possession.cpp b/src/challenge/challenge-possession.cpp
index 7c2b30a..81a0bb6 100644
--- a/src/challenge/challenge-possession.cpp
+++ b/src/challenge/challenge-possession.cpp
@@ -229,7 +229,7 @@
 void
 ChallengePossession::fulfillParameters(std::multimap<std::string, std::string>& params,
                                        ndn::KeyChain& keyChain, const Name& issuedCertName,
-                                       const std::array<uint8_t, 16>& nonce)
+                                       ndn::span<const uint8_t, 16> nonce)
 {
   auto keyName = ndn::security::extractKeyNameFromCertName(issuedCertName);
   auto id = keyChain.getPib().getIdentity(ndn::security::extractIdentityFromCertName(issuedCertName));

src/challenge/challenge-possession.hpp

diff --git a/src/challenge/challenge-possession.hpp b/src/challenge/challenge-possession.hpp
index ab5e641..0aa78c3 100644
--- a/src/challenge/challenge-possession.hpp
+++ b/src/challenge/challenge-possession.hpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017-2021, Regents of the University of California.
+ * Copyright (c) 2017-2022, Regents of the University of California.
  *
  * This file is part of ndncert, a certificate management system based on NDN.
  *
@@ -51,6 +51,7 @@
 class ChallengePossession : public ChallengeModule
 {
 public:
+  explicit
   ChallengePossession(const std::string& configPath = "");
 
   // For CA
@@ -68,7 +69,7 @@
   static void
   fulfillParameters(std::multimap<std::string, std::string>& params,
                     ndn::KeyChain& keyChain, const Name& issuedCertName,
-                    const std::array<uint8_t, 16>& nonce);
+                    ndn::span<const uint8_t, 16> nonce);
 
   // challenge parameters
   static const std::string PARAMETER_KEY_CREDENTIAL_CERT;