commit 938d703bdd4446b4f1d69f86f5106c4b7f038637
author Zhiyi Zhang <zhiyi@cs.ucla.edu> Mon Oct 12 17:23:45 2020 -0700
committer Zhiyi Zhang <zhiyi@cs.ucla.edu> Mon Oct 12 17:23:45 2020 -0700
tree 9b81a09070523923239f582eabede3bd6c04630d
parent a3e62bd5b0984aab1eb81457b8dfd1eea9a08353

fix a warning

Change-Id: Ifbc276267cccedf177f40fe5fdb965f9056d96ee

src/protocol-detail/crypto-helper.cpp

diff --git a/src/protocol-detail/crypto-helper.cpp b/src/protocol-detail/crypto-helper.cpp
index 389e0b4..5a56ab1 100644
--- a/src/protocol-detail/crypto-helper.cpp
+++ b/src/protocol-detail/crypto-helper.cpp
@@ -138,7 +138,7 @@
   auto ecPoint = EC_KEY_get0_public_key(privECKey);
   const EC_GROUP* group = EC_KEY_get0_group(privECKey);
   m_publicKeyLen = EC_POINT_point2oct(group, ecPoint, POINT_CONVERSION_COMPRESSED,
-                                    m_publicKey, 256, nullptr);
+                                      m_publicKey, 256, nullptr);
   EC_KEY_free(privECKey);
   if (m_publicKeyLen == 0) {
     handleErrors("Could not convert EC_POINTS to octet string when calling EC_POINT_point2oct.");
@@ -180,11 +180,13 @@
     handleErrors("Cannot convert peer's key into a EC point when calling EC_POINT_oct2point()");
   }
 
-  if (-1 == (m_sharedSecretLen = ECDH_compute_key(m_sharedSecret, 256, peerPoint, privECKey, nullptr))) {
+  result = ECDH_compute_key(m_sharedSecret, 256, peerPoint, privECKey, nullptr);
+  if (result == -1) {
     EC_POINT_free(peerPoint);
     EC_KEY_free(privECKey);
     handleErrors("Cannot generate ECDH secret when calling ECDH_compute_key()");
   }
+  m_sharedSecretLen = static_cast<size_t>(result);
   EC_POINT_free(peerPoint);
   EC_KEY_free(privECKey);
   return m_sharedSecret;