commit 621a3b54bcbf11d5f6b297118c10b92870deb5b1
author Zhiyi Zhang <zhiyi@cs.ucla.edu> Sat Oct 03 21:55:11 2020 -0700
committer Zhiyi Zhang <zhiyi@cs.ucla.edu> Sat Oct 03 21:55:11 2020 -0700
tree 611d562b2bebbc1532fc3a14f29e9937974a6d19
parent 122fcfc78f40f74f931ca5b8970cac63b559bd47

fix one test error

Change-Id: Id116e8637afe18b0c53aaf14521145e431044b43

tests/unit-tests/challenge-credential.t.cpp

diff --git a/tests/unit-tests/challenge-credential.t.cpp b/tests/unit-tests/challenge-credential.t.cpp
index 2f31433..0854155 100644
--- a/tests/unit-tests/challenge-credential.t.cpp
+++ b/tests/unit-tests/challenge-credential.t.cpp
@@ -55,7 +55,7 @@
   auto identityA = addIdentity(Name("/example"));
   auto keyA = identityA.getDefaultKey();
   auto certA = key.getDefaultCertificate();
-  RequestState request(Name("/example"), "123", RequestType::NEW, Status::BEFORE_CHALLENGE, certA, makeEmptyBlock(tlv::ContentType_Key));
+  RequestState state(Name("/example"), "123", RequestType::NEW, Status::BEFORE_CHALLENGE, certA, makeEmptyBlock(tlv::ContentType_Key));
 
   // create requester's credential
   auto identityB = addIdentity(Name("/trust/cert"));
@@ -69,40 +69,11 @@
   m_keyChain.sign(credential, signingByCertificate(trustAnchor).setSignatureInfo(signatureInfo));
 
   // using private key to sign cert request
-  Name idSignatureName = credential.getKeyName();
-  idSignatureName.append("request-id-signature").appendVersion();
-  security::v2::Certificate idSignature;
-  idSignature.setName(idSignatureName);
-  idSignature.setContent(makeStringBlock(tlv::Content, "123"));
-  m_keyChain.sign(idSignature, signingByCertificate(credential));
-
-  std::stringstream ss;
-  io::save<security::v2::Certificate>(idSignature, ss);
-  auto checkCert = *(io::load<security::v2::Certificate>(ss));
-  BOOST_CHECK_EQUAL(checkCert, idSignature);
-  ss.str("");
-  ss.clear();
-
-  io::save<security::v2::Certificate>(idSignature, ss);
-  std::string idSignatureStr = ss.str();
-  ss.str("");
-  ss.clear();
-
-  io::save<security::v2::Certificate>(credential, ss);
-  std::string credentialStr = ss.str();
-  ss.str("");
-  ss.clear();
-
-  Block params = makeEmptyBlock(tlv_encrypted_payload);
-  params.push_back(makeStringBlock(tlv_selected_challenge, "Credential"));
-  params.push_back(makeStringBlock(tlv_parameter_key, ChallengeCredential::PARAMETER_KEY_CREDENTIAL_CERT));
-  params.push_back(makeStringBlock(tlv_parameter_value, credentialStr));
-  params.push_back(makeStringBlock(tlv_parameter_key, ChallengeCredential::PARAMETER_KEY_PROOF_OF_PRIVATE_KEY));
-  params.push_back(makeStringBlock(tlv_parameter_value, idSignatureStr));
-  params.encode();
-
-  challenge.handleChallengeRequest(params, request);
-  BOOST_CHECK(request.m_status == Status::PENDING);
+  std::vector<std::tuple<std::string, std::string>> params;
+  ChallengeCredential::fulfillParameters(params, m_keyChain, credential.getName(), "123");
+  Block paramsTlv = challenge.genChallengeRequestTLV(Status::BEFORE_CHALLENGE, "", std::move(params));
+  challenge.handleChallengeRequest(paramsTlv, state);
+  BOOST_CHECK(state.m_status == Status::PENDING);
 }
 
 BOOST_AUTO_TEST_SUITE_END()

tests/unit-tests/requester.t.cpp

diff --git a/tests/unit-tests/requester.t.cpp b/tests/unit-tests/requester.t.cpp
index 3c125d8..4b7e224 100644
--- a/tests/unit-tests/requester.t.cpp
+++ b/tests/unit-tests/requester.t.cpp
@@ -52,7 +52,7 @@
 
   BOOST_CHECK(firstInterest->getName().at(-1).isParametersSha256Digest());
   // ignore the last name component (ParametersSha256Digest)
-  BOOST_CHECK_EQUAL(firstInterest->getName().getPrefix(-1), "/site/CA/PROBE");		
+  BOOST_CHECK_EQUAL(firstInterest->getName().getPrefix(-1), "/site/CA/PROBE");
   BOOST_CHECK_EQUAL(readString(firstInterest->getApplicationParameters().get(tlv_parameter_value)), "zhiyi@cs.ucla.edu");
 }