CR fix 2
Change-Id: Ib5b7d7ff17f6ae31e9b6d905ef53d015a7389ccc
diff --git a/src/detail/challenge-encoder.cpp b/src/detail/challenge-encoder.cpp
index 6d68869..0cc98a3 100644
--- a/src/detail/challenge-encoder.cpp
+++ b/src/detail/challenge-encoder.cpp
@@ -26,7 +26,7 @@
Block
challengeEncoder::encodeDataContent(ca::RequestState& request, const Name& issuedCertName)
{
- Block response = makeEmptyBlock(tlv::EncryptedPayload);
+ Block response(tlv::EncryptedPayload);
response.push_back(makeNonNegativeIntegerBlock(tlv::Status, static_cast<uint64_t>(request.m_status)));
if (request.m_challengeState) {
response.push_back(makeStringBlock(tlv::ChallengeStatus, request.m_challengeState->m_challengeStatus));
diff --git a/src/detail/crypto-helpers.cpp b/src/detail/crypto-helpers.cpp
index 3142268..cc09a95 100644
--- a/src/detail/crypto-helpers.cpp
+++ b/src/detail/crypto-helpers.cpp
@@ -356,7 +356,7 @@
uint8_t tag[16];
size_t encryptedPayloadLen = aesGcm128Encrypt(payload, payloadSize, associatedData, associatedDataSize,
key, iv.data(), encryptedPayload.data(), tag);
- auto content = makeEmptyBlock(tlvType);
+ Block content(tlvType);
content.push_back(makeBinaryBlock(tlv::InitializationVector, iv.data(), iv.size()));
content.push_back(makeBinaryBlock(tlv::AuthenticationTag, tag, 16));
content.push_back(makeBinaryBlock(tlv::EncryptedPayload, encryptedPayload.data(), encryptedPayloadLen));
diff --git a/src/detail/error-encoder.cpp b/src/detail/error-encoder.cpp
index 8d30103..b503f86 100644
--- a/src/detail/error-encoder.cpp
+++ b/src/detail/error-encoder.cpp
@@ -26,7 +26,7 @@
Block
errorEncoder::encodeDataContent(ErrorCode errorCode, const std::string& description)
{
- Block response = makeEmptyBlock(ndn::tlv::Content);
+ Block response(ndn::tlv::Content);
response.push_back(makeNonNegativeIntegerBlock(tlv::ErrorCode, static_cast<size_t>(errorCode)));
response.push_back(makeStringBlock(tlv::ErrorInfo, description));
response.encode();
diff --git a/src/detail/info-encoder.cpp b/src/detail/info-encoder.cpp
index 0a26f8a..746aafc 100644
--- a/src/detail/info-encoder.cpp
+++ b/src/detail/info-encoder.cpp
@@ -26,7 +26,7 @@
Block
infoEncoder::encodeDataContent(const CaProfile& caConfig, const security::Certificate& certificate)
{
- auto content = makeEmptyBlock(ndn::tlv::Content);
+ Block content(ndn::tlv::Content);
content.push_back(makeNestedBlock(tlv::CaPrefix, caConfig.m_caPrefix));
std::string caInfo = "";
if (caConfig.m_caInfo == "") {
diff --git a/src/detail/new-renew-revoke-encoder.cpp b/src/detail/new-renew-revoke-encoder.cpp
index 0863d9b..bdde1cf 100644
--- a/src/detail/new-renew-revoke-encoder.cpp
+++ b/src/detail/new-renew-revoke-encoder.cpp
@@ -32,7 +32,7 @@
newRenewRevokeEncoder::encodeApplicationParameters(RequestType requestType, const std::vector<uint8_t>& ecdhPub,
const security::Certificate& certRequest)
{
- Block request = makeEmptyBlock(ndn::tlv::ApplicationParameters);
+ Block request(ndn::tlv::ApplicationParameters);
std::stringstream ss;
try {
security::transform::bufferSource(certRequest.wireEncode().wire(), certRequest.wireEncode().size())
@@ -84,7 +84,7 @@
const RequestId& requestId, const Status& status,
const std::list<std::string>& challenges)
{
- Block response = makeEmptyBlock(ndn::tlv::Content);
+ Block response(ndn::tlv::Content);
response.push_back(makeBinaryBlock(tlv::EcdhPub, ecdhKey.data(), ecdhKey.size()));
response.push_back(makeBinaryBlock(tlv::Salt, salt.data(), salt.size()));
response.push_back(makeBinaryBlock(tlv::RequestId, requestId.data(), requestId.size()));
diff --git a/src/detail/probe-encoder.cpp b/src/detail/probe-encoder.cpp
index a4271f5..2a5fa08 100644
--- a/src/detail/probe-encoder.cpp
+++ b/src/detail/probe-encoder.cpp
@@ -26,7 +26,7 @@
Block
probeEncoder::encodeApplicationParameters(std::vector<std::tuple<std::string, std::string>>&& parameters)
{
- auto content = makeEmptyBlock(ndn::tlv::ApplicationParameters);
+ Block content(ndn::tlv::ApplicationParameters);
for (size_t i = 0; i < parameters.size(); ++i) {
content.push_back(makeStringBlock(tlv::ParameterKey, std::get<0>(parameters[i])));
content.push_back(makeStringBlock(tlv::ParameterValue, std::get<1>(parameters[i])));
@@ -40,9 +40,10 @@
{
std::vector<std::tuple<std::string, std::string>> result;
block.parse();
- for (size_t i = 0; i < block.elements().size() - 1; ++i) {
- if (block.elements().at(i).type() == tlv::ParameterKey && block.elements().at(i + 1).type() == tlv::ParameterValue) {
- result.push_back(std::make_tuple(readString(block.elements().at(i)), readString(block.elements().at(i + 1))));
+ for (size_t i = 0; i < block.elements().size() - 1; i++) {
+ if (block.elements()[i].type() == tlv::ParameterKey && block.elements()[i + 1].type() == tlv::ParameterValue) {
+ result.emplace_back(readString(block.elements().at(i)), readString(block.elements().at(i + 1)));
+ i ++;
}
}
return result;
@@ -52,7 +53,7 @@
probeEncoder::encodeDataContent(const std::vector<Name>& identifiers, optional<size_t> maxSuffixLength,
optional<std::vector<std::shared_ptr<security::Certificate>>> redirectionItems)
{
- Block content = makeEmptyBlock(ndn::tlv::Content);
+ Block content(ndn::tlv::Content);
for (const auto& name : identifiers) {
Block item(tlv::ProbeResponse);
item.push_back(name.wireEncode());
@@ -81,7 +82,7 @@
item.parse();
Name elementName;
int maxSuffixLength = 0;
- for (const auto& subBlock: item.elements()) {
+ for (const auto& subBlock : item.elements()) {
if (subBlock.type() == ndn::tlv::Name) {
if (!elementName.empty()) {
NDN_THROW(std::runtime_error("Invalid probe format"));