commit 1013078297078fce5d2a125da79ff93a985dc3fc
author Zhiyi Zhang <zhiyi@cs.ucla.edu> Thu Feb 01 18:28:49 2018 -0800
committer Zhiyi Zhang <zhiyi@cs.ucla.edu> Sat Feb 03 12:28:27 2018 -0800
tree 86c853c08334c123e4efd9154679469578958e89
parent 916ba2d55deceb0a47cca24c78fae6e27ba554b2

Avoid creating two new keys when using ndncert-client

Change-Id: I0d7f523532bca535ac0d5cae34f80f241d9b1db6

src/client-module.cpp

diff --git a/src/client-module.cpp b/src/client-module.cpp
index 0d98d90..fff47af 100644
--- a/src/client-module.cpp
+++ b/src/client-module.cpp
@@ -192,10 +192,17 @@
                       const RequestCallback& requestCallback,
                       const ErrorCallback& errorCallback)
 {
-  security::Identity identity = m_keyChain.createIdentity(identityName);
+  const auto& pib = m_keyChain.getPib();
 
   auto state = make_shared<RequestState>();
-  state->m_key = m_keyChain.createKey(identity);
+  try {
+    auto identity = pib.getIdentity(identityName);
+    state->m_key = m_keyChain.createKey(identity);
+  }
+  catch (const security::Pib::Error& e) {
+    auto identity = m_keyChain.createIdentity(identityName);
+    state->m_key = identity.getDefaultKey();
+  }
   state->m_ca = ca;
   state->m_isInstalled = false;
 

tests/unit-tests/client-module.t.cpp

diff --git a/tests/unit-tests/client-module.t.cpp b/tests/unit-tests/client-module.t.cpp
index 777948f..b65b09b 100644
--- a/tests/unit-tests/client-module.t.cpp
+++ b/tests/unit-tests/client-module.t.cpp
@@ -1,6 +1,6 @@
 /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */
 /**
- * Copyright (c) 2017, Regents of the University of California.
+ * Copyright (c) 2017-2018, Regents of the University of California.
  *
  * This file is part of ndncert, a certificate management system based on NDN.
  *
@@ -18,8 +18,8 @@
  * See AUTHORS.md for complete list of ndncert authors and contributors.
  */
 
-#include "identity-management-fixture.hpp"
 #include "client-module.hpp"
+#include "identity-management-fixture.hpp"
 #include "challenge-module.hpp"
 #include <ndn-cxx/util/dummy-client-face.hpp>
 #include <ndn-cxx/security/signing-helpers.hpp>
@@ -46,7 +46,7 @@
   ClientModule client(face, m_keyChain);
   client.getClientConf().load("tests/unit-tests/client.conf.test");
 
-  auto identity = addIdentity(Name("/site/CA"));
+  auto identity = addIdentity(Name("/site"));
   auto key = identity.getDefaultKey();
   auto cert = key.getDefaultCertificate();
 
@@ -65,7 +65,7 @@
 
       auto data = make_shared<Data>();
       data->setName(interest.getName());
-      JsonSection json = genResponseProbeJson(Name("/site/CA/ucla-cs-zhiyi"), Name(""));
+      JsonSection json = genResponseProbeJson(Name("/site/ucla-cs-zhiyi"), Name(""));
       std::stringstream ss;
       boost::property_tree::write_json(ss, json);
       Block dataContent = makeStringBlock(ndn::tlv::Content, ss.str());
@@ -110,7 +110,12 @@
   BOOST_CHECK_EQUAL(nInterest, 2);
   BOOST_CHECK_EQUAL(nCallback, 1);
   BOOST_CHECK_EQUAL(requestState->m_ca.m_caName.toUri(), "/site/CA");
-  BOOST_CHECK_EQUAL(requestState->m_key.getName().getPrefix(4).toUri(), "/site/CA/ucla-cs-zhiyi/KEY");
+  BOOST_CHECK_EQUAL(requestState->m_key.getName().getPrefix(3).toUri(), "/site/ucla-cs-zhiyi/KEY");
+
+  // make sure the client did not generate duplicated new keys
+  auto clientIdentity = m_keyChain.getPib().getIdentity(Name("/site/ucla-cs-zhiyi"));
+  const auto& clientKeys = clientIdentity.getKeys();
+  BOOST_CHECK_EQUAL(clientKeys.size(), 1);
 }
 
 BOOST_AUTO_TEST_SUITE_END() // TestClientModule