face: revert unintended behavior change in Transport::setPersistency
Prior to commit 32dab97321d954800f70e4a695e326c998d37a93, persistency
transitions from NONE were not logged and before/afterChangePersistency
was not called. Restore that behavior.
This commit also improves test coverage of the persistency-related
functions in the various Transport subclasses.
Change-Id: Ide77c67ea277fca3d1cad5ea131ae0fa259db75c
Refs: #3232
diff --git a/daemon/face/transport.hpp b/daemon/face/transport.hpp
index 3db4714..ff5363f 100644
--- a/daemon/face/transport.hpp
+++ b/daemon/face/transport.hpp
@@ -221,16 +221,13 @@
ndn::nfd::FacePersistency
getPersistency() const;
- /** \brief check whether the intended change from the current persistency to \p newPersistency
- * can be performed
+ /** \brief check whether the face persistency can be changed to \p newPersistency
*
- * This function serves as an external API, and invokes the internal function
- * canChangePersistencyToImpl to perform further checks if \p newPersistency differs from
- * the current persistency.
+ * This function serves as the external API, and invokes the protected function
+ * canChangePersistencyToImpl to perform further checks if \p newPersistency differs
+ * from the current persistency.
*
- * \pre getPersistency() != NONE
- *
- * \return true if the intended change can be performed, otherwise false
+ * \return true if the change can be performed, false otherwise
*/
bool
canChangePersistencyTo(ndn::nfd::FacePersistency newPersistency) const;
@@ -238,7 +235,7 @@
/** \brief changes face persistency setting
*/
void
- setPersistency(ndn::nfd::FacePersistency persistency);
+ setPersistency(ndn::nfd::FacePersistency newPersistency);
/** \return whether face is point-to-point or multi-access
*/