commit 1b65ca19008045e6d6a17c260b00a8d4864b560f
author Junxiao Shi <git@mail1.yoursunny.com> Sat Jan 21 23:04:41 2017 +0000
committer Junxiao Shi <git@mail1.yoursunny.com> Sat Jan 21 23:04:41 2017 +0000
tree b45179a9bb7c4e896bc065bab8c2b6ce05c2e56b
parent 3409cd399dd110d9356e148bf790ac82e865e678

tests: delete BOOST_CHECK_NO_THROW in ProtocolFactory test suites

This makes exception message appear in testing logs, which
simplifies debugging.

refs #3904

Change-Id: I7d1a36c1c66d885a03e6a6d283e2907364f7f31a

tests/daemon/face/ethernet-factory.t.cpp

diff --git a/tests/daemon/face/ethernet-factory.t.cpp b/tests/daemon/face/ethernet-factory.t.cpp
index 7c7f295..62748cd 100644
--- a/tests/daemon/face/ethernet-factory.t.cpp
+++ b/tests/daemon/face/ethernet-factory.t.cpp
@@ -84,8 +84,8 @@
     }
   )CONFIG";
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG, true));
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG, false));
+  parseConfig(CONFIG, true);
+  parseConfig(CONFIG, false);
 
   BOOST_CHECK_EQUAL(this->countEtherMcastFaces(), netifs.size());
 }
@@ -98,8 +98,8 @@
     }
   )CONFIG";
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG, true));
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG, false));
+  parseConfig(CONFIG, true);
+  parseConfig(CONFIG, false);
 
   BOOST_CHECK_EQUAL(this->countEtherMcastFaces(), 0);
 }
@@ -122,7 +122,7 @@
   )CONFIG";
   boost::replace_first(CONFIG, "%ifname", netifs.front().name);
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG, false));
+  parseConfig(CONFIG, false);
   auto etherMcastFaces = this->listEtherMcastFaces();
   BOOST_REQUIRE_EQUAL(etherMcastFaces.size(), 1);
   BOOST_CHECK_EQUAL(etherMcastFaces.front()->getLocalUri().getHost(), netifs.front().name);
@@ -146,7 +146,7 @@
   )CONFIG";
   boost::replace_first(CONFIG, "%ifname", netifs.front().name);
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG, false));
+  parseConfig(CONFIG, false);
   auto etherMcastFaces = this->listEtherMcastFaces();
   BOOST_CHECK_EQUAL(etherMcastFaces.size(), netifs.size() - 1);
   BOOST_CHECK_EQUAL(boost::count_if(etherMcastFaces, [=] (const Face* face) {
@@ -175,16 +175,16 @@
     }
   )CONFIG";
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG_WITHOUT_MCAST, false));
+  parseConfig(CONFIG_WITHOUT_MCAST, false);
   BOOST_CHECK_EQUAL(this->countEtherMcastFaces(), 0);
 
   SKIP_IF_ETHERNET_NETIF_COUNT_LT(1);
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG_WITH_MCAST, false));
+  parseConfig(CONFIG_WITH_MCAST, false);
   g_io.poll();
   BOOST_CHECK_EQUAL(this->countEtherMcastFaces(), netifs.size());
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG_WITHOUT_MCAST, false));
+  parseConfig(CONFIG_WITHOUT_MCAST, false);
   g_io.poll();
   BOOST_CHECK_EQUAL(this->countEtherMcastFaces(), 0);
 }
@@ -212,13 +212,13 @@
     }
   )CONFIG";
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG1, false));
+  parseConfig(CONFIG1, false);
   auto etherMcastFaces = this->listEtherMcastFaces();
   BOOST_REQUIRE_EQUAL(etherMcastFaces.size(), netifs.size());
   BOOST_CHECK_EQUAL(etherMcastFaces.front()->getRemoteUri(),
                     FaceUri(ethernet::Address(0x01, 0x00, 0x00, 0x00, 0x00, 0x01)));
 
-  BOOST_CHECK_NO_THROW(parseConfig(CONFIG2, false));
+  parseConfig(CONFIG2, false);
   g_io.poll();
   etherMcastFaces = this->listEtherMcastFaces();
   BOOST_REQUIRE_EQUAL(etherMcastFaces.size(), netifs.size());