mgmt: refactor management modules to conform to NFD Management Protocol
Refactor management protocol specific option types to ControlParameters
Add control parameter field enforcement
Add missing control response "success" message bodies
Update fib management protocol response codes and behavior
Merge local control header manager into face manager
Refactor references of nfd::LocalControlHeaderFeature enum to ndn::nfd::LocalControlFeature
Remove "control-header" privilege from default configuration
refs: #1397, #1399, #1400
Change-Id: Id042daf00b3cee1f1c7fa38d2e4a4ff6d95c15c6
diff --git a/daemon/mgmt/manager-base.cpp b/daemon/mgmt/manager-base.cpp
index ad26e53..af5fc37 100644
--- a/daemon/mgmt/manager-base.cpp
+++ b/daemon/mgmt/manager-base.cpp
@@ -21,6 +21,24 @@
}
+bool
+ManagerBase::extractParameters(const Name::Component& parameterComponent,
+ ControlParameters& extractedParameters)
+{
+ try
+ {
+ Block rawParameters = parameterComponent.blockFromValue();
+ extractedParameters.wireDecode(rawParameters);
+ }
+ catch (const ndn::Tlv::Error& e)
+ {
+ return false;
+ }
+
+ NFD_LOG_DEBUG("Parameters parsed OK");
+ return true;
+}
+
void
ManagerBase::sendResponse(const Name& name,
uint32_t code,
@@ -32,6 +50,17 @@
void
ManagerBase::sendResponse(const Name& name,
+ uint32_t code,
+ const std::string& text,
+ const Block& body)
+{
+ ControlResponse response(code, text);
+ response.setBody(body);
+ sendResponse(name, response);
+}
+
+void
+ManagerBase::sendResponse(const Name& name,
const ControlResponse& response)
{
NFD_LOG_DEBUG("responding"