chunks: declare DiscoverVersion destructor virtual
The concrete subclasses are deleted polymorphically
through a unique_ptr<DiscoverVersion>.
Also add -Wnon-virtual-dtor to the default CXXFLAGS
to prevent this from happening in the future.
Change-Id: If00a99566a54c7af4cd27df6fe68dcdef4cb4e82
diff --git a/tools/chunks/catchunks/discover-version.cpp b/tools/chunks/catchunks/discover-version.cpp
index 1d3298e..455fd6a 100644
--- a/tools/chunks/catchunks/discover-version.cpp
+++ b/tools/chunks/catchunks/discover-version.cpp
@@ -1,8 +1,8 @@
/* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */
-/**
- * Copyright (c) 2016, Regents of the University of California,
- * Colorado State University,
- * University Pierre & Marie Curie, Sorbonne University.
+/*
+ * Copyright (c) 2016-2017, Regents of the University of California,
+ * Colorado State University,
+ * University Pierre & Marie Curie, Sorbonne University.
*
* This file is part of ndn-tools (Named Data Networking Essential Tools).
* See AUTHORS.md for complete list of ndn-tools authors and contributors.
@@ -38,9 +38,10 @@
{
}
+DiscoverVersion::~DiscoverVersion() = default;
+
void
-DiscoverVersion::expressInterest(const Interest& interest, int maxRetriesNack,
- int maxRetriesTimeout)
+DiscoverVersion::expressInterest(const Interest& interest, int maxRetriesNack, int maxRetriesTimeout)
{
fetcher = DataFetcher::fetch(m_face, interest, maxRetriesNack, maxRetriesTimeout,
bind(&DiscoverVersion::handleData, this, _1, _2),