commit e245b055a83c2b3c45b8f29828cec0594844a15c
author Davide Pesavento <davide.pesavento@lip6.fr> Tue Oct 31 13:00:44 2017 -0400
committer Davide Pesavento <davide.pesavento@lip6.fr> Sat Nov 04 00:56:57 2017 -0400
tree 136b0e38bdf4468bdeac76fcaf6802ef1268015d
parent 9ced9e690be6809d66acd9529acdf6d1b4af0504

encoding: don't call memcmp() with null pointer

It's undefined behavior.

Change-Id: Id2fd5cbc0483af2bf9857e81fb6cac8163da3474
Refs: #4368

src/name-component.cpp

diff --git a/src/name-component.cpp b/src/name-component.cpp
index 5cf31aa..36a01f9 100644
--- a/src/name-component.cpp
+++ b/src/name-component.cpp
@@ -31,6 +31,7 @@
 #include "util/string-helper.hpp"
 
 #include <boost/algorithm/string/trim.hpp>
+#include <cstring>
 #include <sstream>
 
 namespace ndn {
@@ -387,7 +388,7 @@
 {
   return type() == other.type() &&
          value_size() == other.value_size() &&
-         (empty() || // needed on OSX 10.9 due to STL bug
+         (empty() || // needed with Apple clang < 9.0.0 due to libc++ bug
           std::equal(value_begin(), value_end(), other.value_begin()));
 }
 
@@ -410,7 +411,7 @@
   if (cmpSize != 0)
     return cmpSize;
 
-  if (empty()) // needed on OSX 10.9 due to STL bug
+  if (empty())
     return 0;
 
   return std::memcmp(value(), other.value(), value_size());