commit dd46143beb21d9af025b1ae8ede3e411f2474f5c
author Davide Pesavento <davide.pesavento@lip6.fr> Sat Jan 28 21:47:26 2017 -0500
committer Alexander Afanasyev <alexander.afanasyev@ucla.edu> Mon Jan 30 09:35:48 2017 -0800
tree b6885618abb5b4838230e46cd21fb089fbbc0aa9
parent fdda2411eea09aae961ea950f5ca1673ef23231c

util: remove unnecessary trim/trimLeft/trimRight wrappers

When needed, use boost::algorithm::trim/trim_left/trim_right directly.

Change-Id: I854d89e553c70ab20679a38922cec306fc57824d
Refs: #3006

tests/unit-tests/util/string-helper.t.cpp

diff --git a/tests/unit-tests/util/string-helper.t.cpp b/tests/unit-tests/util/string-helper.t.cpp
index c59804b..c5cc218 100644
--- a/tests/unit-tests/util/string-helper.t.cpp
+++ b/tests/unit-tests/util/string-helper.t.cpp
@@ -20,6 +20,7 @@
  */
 
 #include "util/string-helper.hpp"
+#include "encoding/buffer.hpp"
 
 #include "boost-test.hpp"
 
@@ -108,52 +109,6 @@
   BOOST_CHECK_THROW(fromHex("1234z"), StringHelperError);
 }
 
-BOOST_AUTO_TEST_CASE(Trim)
-{
-  std::string test1 = "Hello, world!";
-  std::string test2 = "\n \t    Hello, world!\n\r   \t ";
-  std::string test3 = "            \t \n \r          ";
-
-  // TrimLeft
-  std::string test = test1;
-  trimLeft(test);
-  BOOST_CHECK_EQUAL(test, "Hello, world!");
-
-  test = test2;
-  trimLeft(test);
-  BOOST_CHECK_EQUAL(test, "Hello, world!\n\r   \t ");
-
-  test = test3;
-  trimLeft(test);
-  BOOST_CHECK_EQUAL(test, "");
-
-  // TrimRight
-  test = test1;
-  trimRight(test);
-  BOOST_CHECK_EQUAL(test, "Hello, world!");
-
-  test = test2;
-  trimRight(test);
-  BOOST_CHECK_EQUAL(test, "\n \t    Hello, world!");
-
-  test = test3;
-  trimRight(test);
-  BOOST_CHECK_EQUAL(test, "");
-
-  // Trim
-  test = test1;
-  trim(test);
-  BOOST_CHECK_EQUAL(test, "Hello, world!");
-
-  test = test2;
-  trim(test);
-  BOOST_CHECK_EQUAL(test, "Hello, world!");
-
-  test = test3;
-  trim(test);
-  BOOST_CHECK_EQUAL(test, "");
-}
-
 BOOST_AUTO_TEST_CASE(Unescape)
 {
   std::string test1 = "Hello%01, world!%AA  ";