commit c008798266710b73925d807b53c226f0e646f849
author Davide Pesavento <davide.pesavento@lip6.fr> Sun Jul 16 23:32:34 2017 -0400
committer Davide Pesavento <davide.pesavento@lip6.fr> Mon Jul 17 10:28:55 2017 -0400
tree 188b19fd8cb75c460e0222f9d3556db77bb51893
parent f35c4270f27660c31f39086d276824aeac65852f

net: NetworkMonitorImplOsx: minimize number of calls to getifaddrs()

Change-Id: I952d68bea780d2a237bffee29adea00dbf8d128a
Refs: #3817

src/net/detail/network-monitor-impl-osx.hpp

diff --git a/src/net/detail/network-monitor-impl-osx.hpp b/src/net/detail/network-monitor-impl-osx.hpp
index 8de354c..7339153 100644
--- a/src/net/detail/network-monitor-impl-osx.hpp
+++ b/src/net/detail/network-monitor-impl-osx.hpp
@@ -1,5 +1,5 @@
 /* -*- Mode:C++; c-file-style:"gnu"; indent-tabs-mode:nil; -*- */
-/**
+/*
  * Copyright (c) 2013-2017 Regents of the University of California.
  *
  * This file is part of ndn-cxx library (NDN C++ library with eXperimental eXtensions).
@@ -41,6 +41,8 @@
 namespace ndn {
 namespace net {
 
+class IfAddrs;
+
 class NetworkMonitorImplOsx : public NetworkMonitorImpl
 {
 public:
@@ -65,38 +67,33 @@
   std::vector<shared_ptr<const NetworkInterface>>
   listNetworkInterfaces() const final;
 
+private:
   static void
-  afterNotificationCenterEvent(CFNotificationCenterRef center,
-                               void* observer,
-                               CFStringRef name,
-                               const void* object,
+  afterNotificationCenterEvent(CFNotificationCenterRef center, void* observer,
+                               CFStringRef name, const void* object,
                                CFDictionaryRef userInfo);
 
-private:
   void
   scheduleCfLoop();
 
   void
-  pollCfLoop();
-
-  void
-  addNewInterface(const std::string& ifName);
-
-  void
   enumerateInterfaces();
 
   std::set<std::string>
-  getInterfaceNames();
-
-  InterfaceState
-  getInterfaceState(const std::string& ifName);
+  getInterfaceNames() const;
 
   void
-  updateInterfaceInfo(NetworkInterface& netif);
+  addNewInterface(const std::string& ifName, const IfAddrs& ifaList);
+
+  InterfaceState
+  getInterfaceState(const std::string& ifName) const;
 
   size_t
   getInterfaceMtu(const std::string& ifName);
 
+  void
+  updateInterfaceInfo(NetworkInterface& netif, const IfAddrs& ifaList);
+
   static void
   onConfigChanged(SCDynamicStoreRef store, CFArrayRef changedKeys, void* context);