commit 9c7ed11a38badab7b63b70d57706e96898e2d4e0
author Alexander Afanasyev <alexander.afanasyev@ucla.edu> Fri Feb 07 12:23:03 2014 -0800
committer Alexander Afanasyev <alexander.afanasyev@ucla.edu> Fri Feb 07 13:00:39 2014 -0800
tree 09b6f0b5083ce72bafd47262d247a1c7bdd34880
parent b46f9702f1b03dc61a601b0e41a20441e7b73976

src: Fixing signed/unsigned comparison warnings and removing all warning-suppressing pragmas

Change-Id: I5526a00d9be6d576bb500d51c0bc6c2ad8cc541d

src/encoding/block.cpp

diff --git a/src/encoding/block.cpp b/src/encoding/block.cpp
index 0785ec0..5656b61 100644
--- a/src/encoding/block.cpp
+++ b/src/encoding/block.cpp
@@ -43,7 +43,7 @@
   m_type = Tlv::readType(m_value_begin, m_value_end);
 
   uint64_t length = Tlv::readVarNumber(m_value_begin, m_value_end);
-  if (length != (m_value_end - m_value_begin))
+  if (length != static_cast<uint64_t>(m_value_end - m_value_begin))
     {
       throw Tlv::Error("TLV length doesn't match buffer length");
     }
@@ -60,7 +60,7 @@
   
   m_type = Tlv::readType(m_value_begin, m_value_end);
   uint64_t length = Tlv::readVarNumber(m_value_begin, m_value_end);
-  if (length != (m_value_end - m_value_begin))
+  if (length != static_cast<uint64_t>(m_value_end - m_value_begin))
     {
       throw Tlv::Error("TLV length doesn't match buffer length");
     }
@@ -84,7 +84,7 @@
   buf[0] = *tmp_begin;
   is.read(buf+1, length-1);
 
-  if(length-1 != is.gcount())
+  if(length != static_cast<uint64_t>(is.gcount())+1)
     {
       delete [] buf;
       throw Tlv::Error("Not enough data in the buffer to fully parse TLV");
@@ -112,7 +112,7 @@
   m_type = Tlv::readType(tmp_begin, tmp_end);
   uint64_t length = Tlv::readVarNumber(tmp_begin, tmp_end);
   
-  if (length > (tmp_end - tmp_begin))
+  if (length > static_cast<uint64_t>(tmp_end - tmp_begin))
     {
       throw Tlv::Error("Not enough data in the buffer to fully parse TLV");
     }
@@ -137,7 +137,7 @@
   m_type = Tlv::readType(tmp_begin, tmp_end);
   uint64_t length = Tlv::readVarNumber(tmp_begin, tmp_end);
   
-  if (length > (tmp_end - tmp_begin))
+  if (length > static_cast<uint64_t>(tmp_end - tmp_begin))
     {
       throw Tlv::Error("Not enough data in the buffer to fully parse TLV");
     }
@@ -195,7 +195,7 @@
       uint32_t type = Tlv::readType(begin, end);
       uint64_t length = Tlv::readVarNumber(begin, end);
 
-      if (end-begin < length)
+      if (length > static_cast<uint64_t>(end - begin))
         {
           m_subBlocks.clear();
           throw Tlv::Error("TLV length exceeds buffer length");
@@ -280,7 +280,7 @@
   uint32_t type = Tlv::readType(begin, end);
   uint64_t length = Tlv::readVarNumber(begin, end);
 
-  if (end-begin != length)
+  if (length != static_cast<uint64_t>(end - begin))
     throw Tlv::Error("TLV length mismatches buffer length");
       
   return Block(m_buffer,