commit 864e8e8c4721276624d9ac3fbceb64b0f73fba62
author Davide Pesavento <davide.pesavento@lip6.fr> Wed Oct 04 23:41:14 2017 -0400
committer Davide Pesavento <davide.pesavento@lip6.fr> Fri Oct 06 13:45:49 2017 -0400
tree 72deac6e167620476a82a396b3afa09c9f74da69
parent ff3bf2cfb8ebbdd5bb3328aba151e44c02690c04

security: remove default argument from transform::digestFilter

The choice of algorithm to use should be an informed and conscious
decision by the application developer. Moreover, no other transform
filter provides a default.

Change-Id: I92081ec802ef6a7158d620e6d9359f22bcca0d41

src/security/tpm/back-end.cpp

diff --git a/src/security/tpm/back-end.cpp b/src/security/tpm/back-end.cpp
index 364b8bb..f15962c 100644
--- a/src/security/tpm/back-end.cpp
+++ b/src/security/tpm/back-end.cpp
@@ -110,15 +110,18 @@
 BackEnd::setKeyName(KeyHandle& keyHandle, const Name& identity, const KeyParams& params)
 {
   name::Component keyId;
+
   switch (params.getKeyIdType()) {
-    case KeyIdType::USER_SPECIFIED:
+    case KeyIdType::USER_SPECIFIED: {
       keyId = params.getKeyId();
       break;
+    }
     case KeyIdType::SHA256: {
       using namespace transform;
-
       OBufferStream os;
-      bufferSource(*keyHandle.derivePublicKey()) >> digestFilter() >> streamSink(os);
+      bufferSource(*keyHandle.derivePublicKey()) >>
+        digestFilter(DigestAlgorithm::SHA256) >>
+        streamSink(os);
       keyId = name::Component(os.buf());
       break;
     }
@@ -128,7 +131,7 @@
       break;
     }
     default: {
-      BOOST_ASSERT(false);
+      BOOST_THROW_EXCEPTION(Error("Unsupported key id type"));
     }
   }
 

src/security/transform/digest-filter.hpp

diff --git a/src/security/transform/digest-filter.hpp b/src/security/transform/digest-filter.hpp
index a9c023e..fe23586 100644
--- a/src/security/transform/digest-filter.hpp
+++ b/src/security/transform/digest-filter.hpp
@@ -64,7 +64,7 @@
 };
 
 unique_ptr<Transform>
-digestFilter(DigestAlgorithm algo = DigestAlgorithm::SHA256);
+digestFilter(DigestAlgorithm algo);
 
 } // namespace transform
 } // namespace security