encoding: remove duplicate buf() and get() methods from Buffer class
Change-Id: If885d4199d6c9df9b9b46664c3641c9a14a77eab
diff --git a/tests/unit-tests/util/segment-fetcher.t.cpp b/tests/unit-tests/util/segment-fetcher.t.cpp
index d80f1ae..dfc2cd8 100644
--- a/tests/unit-tests/util/segment-fetcher.t.cpp
+++ b/tests/unit-tests/util/segment-fetcher.t.cpp
@@ -20,9 +20,9 @@
*/
#include "util/segment-fetcher.hpp"
+
#include "data.hpp"
-#include "encoding/block.hpp"
-#include "lp/nack-header.hpp"
+#include "lp/nack.hpp"
#include "util/dummy-client-face.hpp"
#include "boost-test.hpp"
@@ -44,26 +44,21 @@
public:
Fixture()
: face(io, m_keyChain)
- , nErrors(0)
- , nData(0)
- , dataSize(0)
{
}
- shared_ptr<Data>
+ static shared_ptr<Data>
makeDataSegment(const Name& baseName, uint64_t segment, bool isFinal)
{
const uint8_t buffer[] = "Hello, world!";
auto data = make_shared<Data>(Name(baseName).appendSegment(segment));
data->setContent(buffer, sizeof(buffer));
-
if (isFinal) {
data->setFinalBlockId(data->getName()[-1]);
}
- data = signData(data);
- return data;
+ return signData(data);
}
void
@@ -78,7 +73,7 @@
{
++nData;
dataSize = data->size();
- dataString = std::string(reinterpret_cast<const char*>(data->get()));
+ dataString = std::string(data->get<char>());
}
void
@@ -93,10 +88,10 @@
public:
DummyClientFace face;
- uint32_t nErrors;
- uint32_t lastError;
- uint32_t nData;
- size_t dataSize;
+ uint32_t nErrors = 0;
+ uint32_t lastError = 0;
+ uint32_t nData = 0;
+ size_t dataSize = 0;
std::string dataString;
};
@@ -148,7 +143,7 @@
BOOST_CHECK_EQUAL(dataSize, 14);
const uint8_t buffer[] = "Hello, world!";
- std::string bufferString = std::string(reinterpret_cast<const char*>(buffer));
+ std::string bufferString(reinterpret_cast<const char*>(buffer));
BOOST_CHECK_EQUAL(dataString, bufferString);
@@ -172,9 +167,7 @@
advanceClocks(time::milliseconds(10));
const uint8_t buffer[] = "Hello, world!";
-
- shared_ptr<Data> data = makeData("/hello/world/version0/no-segment");
-
+ auto data = makeData("/hello/world/version0/no-segment");
data->setContent(buffer, sizeof(buffer));
face.receive(*data);
diff --git a/tests/unit-tests/util/sha256.t.cpp b/tests/unit-tests/util/sha256.t.cpp
index 2fec00f..5775785 100644
--- a/tests/unit-tests/util/sha256.t.cpp
+++ b/tests/unit-tests/util/sha256.t.cpp
@@ -48,8 +48,8 @@
statefulSha256.update(input + 3, 1);
ConstBufferPtr digest = statefulSha256.computeDigest();
BOOST_CHECK_EQUAL(digest->size(), Sha256::DIGEST_SIZE);
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(ConstructFromStream)
@@ -63,8 +63,8 @@
BOOST_CHECK_EQUAL(sha.toString(), "315F5BDB76D078C43B8AC0064E4A0164612B1FCE77C869345BFC94C75894EDD3");
ConstBufferPtr digest = sha.computeDigest();
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(Compare)
@@ -98,8 +98,8 @@
ConstBufferPtr digest = statefulSha256.computeDigest();
BOOST_CHECK_EQUAL(statefulSha256.empty(), false);
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(InsertionOperatorString)
@@ -112,8 +112,8 @@
ConstBufferPtr digest = statefulSha256.computeDigest();
BOOST_CHECK_EQUAL(statefulSha256.empty(), false);
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(InsertionOperatorBlock)
@@ -138,8 +138,8 @@
ConstBufferPtr digest = statefulSha256.computeDigest();
BOOST_CHECK_EQUAL(statefulSha256.empty(), false);
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(InsertionOperatorUint64t)
@@ -154,8 +154,8 @@
ConstBufferPtr digest = statefulSha256.computeDigest();
BOOST_CHECK_EQUAL(statefulSha256.empty(), false);
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(Reset)
@@ -186,8 +186,8 @@
auto expected = fromHex("9f64a747e1b97f131fabb6b447296c9b6f0201e79fb3c5356e6c77e89b6a806a");
ConstBufferPtr digest = Sha256::computeDigest(input, sizeof(input));
- BOOST_CHECK_EQUAL_COLLECTIONS(expected->buf(), expected->buf() + expected->size(),
- digest->buf(), digest->buf() + digest->size());
+ BOOST_CHECK_EQUAL_COLLECTIONS(expected->data(), expected->data() + expected->size(),
+ digest->data(), digest->data() + digest->size());
}
BOOST_AUTO_TEST_CASE(Print)