commit 59d67a50e7a4597cb718052a258bf465b966ddb5
author Alexander Afanasyev <alexander.afanasyev@ucla.edu> Thu Apr 03 16:09:31 2014 -0700
committer Alexander Afanasyev <alexander.afanasyev@ucla.edu> Mon Apr 07 21:33:34 2014 -0700
tree 25928c7b162024b0805a76ec832e45eb726dbe92
parent ff2d08fad0f29a7326d6bf587634137acce8ef1d

build: Correction of OSX Security Framework detection

When a non-Apple compiler is used (e.g., gcc-4.8 from macports), OSX
Security Framework cannot be used, but security framework detection was
not failing.  This commit makes security framework optional on OSX
platform, waf will present warning and `*-osx.*` files will not be
compiled in such cases.

Note that on OSX 10.9 even with this fix, compilation with gcc-4.8 will
still fail, because of STL library incompatibility (e.g., boost and
cryptopp libraries usually compiled against Apple-provided STL and
gcc-4.8 uses by default gcc's STL).

Change-Id: Iecc69f8913fa2f5fea62ac22918d6bc0f05d77c4
Refs: #1443

wscript

diff --git a/wscript b/wscript
index 390b54b..4198fa3 100644
--- a/wscript
+++ b/wscript
@@ -57,13 +57,31 @@
     conf.load('default-compiler-flags')
 
     if Utils.unversioned_sys_platform() == "darwin":
-        conf.check_cxx(framework_name='CoreFoundation', uselib_store='OSX_COREFOUNDATION',
-                       mandatory=True)
-        conf.check_cxx(framework_name='CoreServices', uselib_store='OSX_CORESERVICES',
-                       mandatory=True)
-        conf.check_cxx(framework_name='Security', uselib_store='OSX_SECURITY',
-                       define_name='HAVE_SECURITY', use="OSX_COREFOUNDATION", mandatory=True)
-        conf.define('HAVE_OSX_SECURITY', 1)
+        try:
+            codeFragment='''
+#include <CoreFoundation/CoreFoundation.h>
+#include <Security/Security.h>
+#include <Security/SecRandom.h>
+#include <CoreServices/CoreServices.h>
+#include <Security/SecDigestTransform.h>
+
+int main(int argc, char **argv) {
+    (void)argc; (void)argv;
+    return 0;
+}
+'''
+            conf.check_cxx(framework_name='CoreFoundation', uselib_store='OSX_COREFOUNDATION',
+                           mandatory=True)
+            conf.check_cxx(framework_name='CoreServices', uselib_store='OSX_CORESERVICES',
+                           mandatory=True)
+            conf.check_cxx(framework_name='Security', uselib_store='OSX_SECURITY',
+                           define_name='HAVE_SECURITY', use="OSX_COREFOUNDATION",
+                           fragment=codeFragment, mandatory=True)
+            conf.define('HAVE_OSX_SECURITY', 1)
+            conf.env['HAVE_OSX_SECURITY'] = True
+        except:
+            Logs.warn("Compiling on OSX, but CoreFoundation, CoreServices, or Security framework is not functional.")
+            Logs.warn("The frameworks are known to work only with Apple-specific compilers: llvm-gcc-4.2 or clang")
 
     conf.check_cfg(package='sqlite3', args=['--cflags', '--libs'], uselib_store='SQLITE3',
                    mandatory=True)
@@ -108,7 +126,7 @@
 
     conf.env['WITH_PCH'] = conf.options.with_pch
 
-    if Utils.unversioned_sys_platform() == "darwin":
+    if conf.env['HAVE_OSX_SECURITY']:
         conf.env['WITH_OSX_KEYCHAIN'] = conf.options.with_osx_keychain
         if conf.options.with_osx_keychain:
             conf.define('WITH_OSX_KEYCHAIN', 1)
@@ -138,7 +156,7 @@
     if bld.env['WITH_PCH']:
         libndn_cpp.pch="src/common.hpp"
 
-    if Utils.unversioned_sys_platform() == "darwin":
+    if bld.env['HAVE_OSX_SECURITY']:
         libndn_cpp.source += bld.path.ant_glob('src/**/*-osx.cpp')
         libndn_cpp.mac_app = True
         libndn_cpp.use += " OSX_COREFOUNDATION OSX_SECURITY"
@@ -165,7 +183,7 @@
             pkgconfig_cxxflags += Utils.to_list(bld.env['CXXFLAGS_%s' % lib])
 
     EXTRA_FRAMEWORKS = "";
-    if Utils.unversioned_sys_platform() == "darwin":
+    if bld.env['HAVE_OSX_SECURITY']:
         EXTRA_FRAMEWORKS = "-framework CoreFoundation -framework Security"
 
     def uniq(alist):