commit 4bb06bcedf59475618734e28d068d26dc0d1bc5f
author Davide Pesavento <davidepesa@gmail.com> Sat Apr 06 13:59:10 2019 -0400
committer Davide Pesavento <davidepesa@gmail.com> Sat Apr 06 13:59:10 2019 -0400
tree 6ed9cbaa8ac17d4d4436e1d93f8ceef2f7609921
parent 46b04a5f84ad244d73336883958f6b5ecd6d878d

interest: improve the "CanBePrefix unset" warning

Refs: #4581
Change-Id: I4efd885ad4cd502e5fb1630239be08b8f2d39026

ndn-cxx/interest.cpp

diff --git a/ndn-cxx/interest.cpp b/ndn-cxx/interest.cpp
index cebc226..e7ae747 100644
--- a/ndn-cxx/interest.cpp
+++ b/ndn-cxx/interest.cpp
@@ -25,6 +25,10 @@
 
 #include <boost/scope_exit.hpp>
 
+#ifdef NDN_CXX_HAVE_STACKTRACE
+#include <boost/stacktrace/stacktrace.hpp>
+#endif
+
 #include <cstring>
 #include <iostream>
 #include <sstream>
@@ -53,7 +57,7 @@
   }
 
   if (!boost::logic::indeterminate(s_defaultCanBePrefix)) {
-    setCanBePrefix(static_cast<bool>(s_defaultCanBePrefix));
+    setCanBePrefix(bool(s_defaultCanBePrefix));
   }
 }
 
@@ -65,17 +69,28 @@
 
 // ---- encode and decode ----
 
+static void
+warnOnceCanBePrefixUnset()
+{
+  static bool didWarn = false;
+  if (!didWarn) {
+    didWarn = true;
+    std::cerr << "WARNING: Interest.CanBePrefix will be set to false in the near future. "
+              << "Please declare a preferred setting via Interest::setDefaultCanBePrefix.\n";
+#ifdef NDN_CXX_HAVE_STACKTRACE
+    if (std::getenv("NDN_CXX_VERBOSE_CANBEPREFIX_UNSET_WARNING") != nullptr) {
+      std::cerr << boost::stacktrace::stacktrace(2, 64);
+    }
+#endif
+  }
+}
+
 template<encoding::Tag TAG>
 size_t
 Interest::wireEncode(EncodingImpl<TAG>& encoder) const
 {
-  static bool hasDefaultCanBePrefixWarning = false;
   if (!m_isCanBePrefixSet) {
-    if (!hasDefaultCanBePrefixWarning) {
-      std::cerr << "WARNING: Interest.CanBePrefix will be set to 0 in the near future. "
-                << "Please declare a preferred setting via Interest::setDefaultCanBePrefix.";
-      hasDefaultCanBePrefixWarning = true;
-    }
+    warnOnceCanBePrefixUnset();
 #ifdef NDN_CXX_HAVE_TESTS
     if (s_errorIfCanBePrefixUnset) {
       NDN_THROW(std::logic_error("Interest.CanBePrefix is unset"));