commit 009062db2e703c7dde48b96cbe056ade7323ed1d
author Davide Pesavento <davidepesa@gmail.com> Wed Nov 20 00:16:33 2019 -0500
committer Davide Pesavento <davidepesa@gmail.com> Wed Nov 20 20:10:15 2019 -0500
tree e49ac2f0cdb0757b31020fb4d89eb1f56569a97a
parent a421c80b10969d171c2b774dec6ae1ac7aa1d526

name: alternative URI syntax for component types used in naming conventions

Refs: #4777
Change-Id: I4647fee54dffe104ca3cc31d67b0ad44fcf0de76

ndn-cxx/name-component.cpp

diff --git a/ndn-cxx/name-component.cpp b/ndn-cxx/name-component.cpp
index b7b9333..f41fda0 100644
--- a/ndn-cxx/name-component.cpp
+++ b/ndn-cxx/name-component.cpp
@@ -163,7 +163,7 @@
 
   auto ct = detail::getComponentTypeTable().findByUriPrefix(typePrefix);
   if (ct == nullptr) {
-    NDN_THROW(Error("Incorrect TLV-TYPE '" + typePrefix + "' in NameComponent URI"));
+    NDN_THROW(Error("Unknown TLV-TYPE '" + typePrefix + "' in NameComponent URI"));
   }
   return ct->parseAltUriValue(input.substr(equalPos + 1));
 }
@@ -187,16 +187,15 @@
 bool
 Component::isNumber() const
 {
-  return (value_size() == 1 || value_size() == 2 ||
-          value_size() == 4 || value_size() == 8);
+  return value_size() == 1 || value_size() == 2 ||
+         value_size() == 4 || value_size() == 8;
 }
 
 bool
 Component::isNumberWithMarker(uint8_t marker) const
 {
-  return (!empty() && value()[0] == marker &&
-          (value_size() == 2 || value_size() == 3 ||
-           value_size() == 5 || value_size() == 9));
+  return (value_size() == 2 || value_size() == 3 ||
+          value_size() == 5 || value_size() == 9) && value()[0] == marker;
 }
 
 bool