Fix issues identified by static code analysis
- Class fields should not have public visibility
- Utility classes should not have public constructors
- Loggers should be "private static final" and should share a naming convention
- And more: cyclomatic complexity, class/method size, etc.
diff --git a/src/test/java/com/intel/jndn/mock/MockFaceTest.java b/src/test/java/com/intel/jndn/mock/MockFaceTest.java
index 9682f95..32a8d35 100644
--- a/src/test/java/com/intel/jndn/mock/MockFaceTest.java
+++ b/src/test/java/com/intel/jndn/mock/MockFaceTest.java
@@ -193,8 +193,7 @@
/////////////////////////////////////////////////////////////////////////////
- private void
- run(int limit, int maxCounter) throws IOException, EncodingException, InterruptedException {
+ private void run(int limit, int maxCounter) throws IOException, EncodingException, InterruptedException {
// process face until a response is received
int allowedLoops = limit;
while (counter < maxCounter && allowedLoops > 0) {
@@ -204,8 +203,7 @@
}
}
- private void
- run(int limit) throws IOException, EncodingException, InterruptedException {
+ private void run(int limit) throws IOException, EncodingException, InterruptedException {
run(limit, 1);
}
@@ -231,7 +229,6 @@
/////////////////////////////////////////////////////////////////////////////
private static final Logger logger = Logger.getLogger(MockFaceTest.class.getName());
-
private MockFace face;
private int counter;
private Data recvData = null;