face: remove EndpointId from egress APIs
This commit partially reverts 075bb7dac4bf72cbfcff5e3c2da25c6476090787
refs: #4843, #4973
Change-Id: Iab92addff2bd0fa1e24100d43f9f7076ee84a3f8
diff --git a/tests/daemon/face/generic-link-service.t.cpp b/tests/daemon/face/generic-link-service.t.cpp
index 130c85e..b78ada6 100644
--- a/tests/daemon/face/generic-link-service.t.cpp
+++ b/tests/daemon/face/generic-link-service.t.cpp
@@ -106,7 +106,7 @@
initialize(options);
auto interest1 = makeInterest("/localhost/test");
- face->sendInterest(*interest1, 0);
+ face->sendInterest(*interest1);
BOOST_CHECK_EQUAL(service->getCounters().nOutInterests, 1);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
@@ -123,7 +123,7 @@
initialize(options);
auto data1 = makeData("/localhost/test");
- face->sendData(*data1, 0);
+ face->sendData(*data1);
BOOST_CHECK_EQUAL(service->getCounters().nOutData, 1);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
@@ -167,7 +167,7 @@
// Send Data with less than MIN_MTU octets
auto data1 = makeData("/localhost");
BOOST_CHECK_LE(data1->wireEncode().size(), MIN_MTU);
- face->sendData(*data1, 0);
+ face->sendData(*data1);
BOOST_CHECK_EQUAL(service->getCounters().nOutData, 1);
BOOST_CHECK_EQUAL(service->getCounters().nOutOverMtu, 0);
@@ -175,7 +175,7 @@
// Send Data with more than MIN_MTU octets
auto data2 = makeData("/localhost/test/1234567890/1234567890/1234567890/1234567890");
BOOST_CHECK_GT(data2->wireEncode().size(), MIN_MTU);
- face->sendData(*data2, 0);
+ face->sendData(*data2);
BOOST_CHECK_EQUAL(service->getCounters().nOutData, 2);
BOOST_CHECK_EQUAL(service->getCounters().nOutOverMtu, 1);
@@ -196,7 +196,7 @@
auto nack1 = makeNack(*makeInterest("/localhost/test", false, nullopt, 323),
lp::NackReason::NO_ROUTE);
- face->sendNack(nack1, 0);
+ face->sendNack(nack1);
BOOST_CHECK_EQUAL(service->getCounters().nOutNacks, 1);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
@@ -331,7 +331,7 @@
transport->setMtu(55);
auto data = makeData("/test/data/123456789/987654321/123456789");
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_CHECK_EQUAL(transport->sentPackets.size(), 0);
BOOST_CHECK_EQUAL(service->getCounters().nOutOverMtu, 1);
@@ -349,7 +349,7 @@
transport->setMtu(0);
auto data = makeData("/test/data/123456789/987654321/123456789");
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_CHECK_EQUAL(transport->sentPackets.size(), 0);
BOOST_CHECK_EQUAL(service->getCounters().nOutOverMtu, 1);
@@ -365,7 +365,7 @@
transport->setMtu(MTU_UNLIMITED);
auto data = makeData("/test/data/123456789/987654321/123456789");
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_CHECK_EQUAL(transport->sentPackets.size(), 1);
}
@@ -380,7 +380,7 @@
transport->setMtu(105);
auto data = makeData("/test/data/123456789/987654321/123456789");
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_CHECK_EQUAL(transport->sentPackets.size(), 1);
}
@@ -395,7 +395,7 @@
transport->setMtu(60);
auto data = makeData("/test/data/123456789/987654321/123456789");
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_CHECK_GT(transport->sentPackets.size(), 1);
}
@@ -412,7 +412,7 @@
transport->setMtu(0);
auto data = makeData("/test/data/123456789/987654321/123456789");
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_CHECK_EQUAL(transport->sentPackets.size(), 0);
BOOST_CHECK_EQUAL(service->getCounters().nFragmentationErrors, 1);
@@ -504,7 +504,7 @@
initialize(options);
auto interest1 = makeInterest("/localhost/test");
- face->sendInterest(*interest1, 0);
+ face->sendInterest(*interest1);
BOOST_CHECK_EQUAL(service->getCounters().nOutInterests, 1);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
@@ -522,7 +522,7 @@
initialize(options);
auto data1 = makeData("/localhost/test");
- face->sendData(*data1, 0);
+ face->sendData(*data1);
BOOST_CHECK_EQUAL(service->getCounters().nOutData, 1);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
@@ -541,7 +541,7 @@
auto nack1 = makeNack(*makeInterest("/localhost/test", false, nullopt, 323),
lp::NackReason::NO_ROUTE);
- face->sendNack(nack1, 0);
+ face->sendNack(nack1);
BOOST_CHECK_EQUAL(service->getCounters().nOutNacks, 1);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
@@ -599,7 +599,7 @@
// no congestion
transport->setSendQueueLength(0);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet pkt1(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt1.count<lp::CongestionMarkField>(), 0);
@@ -609,7 +609,7 @@
// no congestion
transport->setSendQueueLength(32768);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 2);
lp::Packet pkt2(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt2.count<lp::CongestionMarkField>(), 0);
@@ -632,7 +632,7 @@
// first congested packet, will not be marked
transport->setSendQueueLength(65537);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet pkt0(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt0.count<lp::CongestionMarkField>(), 0);
@@ -644,7 +644,7 @@
std::sqrt(service->m_nMarkedSinceInMarkingState + 1)));
advanceClocks(markingInterval + 1_ms);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
lp::Packet pkt1(transport->sentPackets.back().packet);
// First congestion mark appears after one interval (100 ms)
@@ -658,7 +658,7 @@
// second congested packet, but within marking interval, will not be marked
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 3);
lp::Packet pkt2(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt2.count<lp::CongestionMarkField>(), 0);
@@ -677,7 +677,7 @@
// first congested packet after waiting marking interval, will be marked
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 4);
lp::Packet pkt3(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt3.count<lp::CongestionMarkField>(), 1);
@@ -695,7 +695,7 @@
// still congested, but within marking interval cycle
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 5);
lp::Packet pkt4(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt4.count<lp::CongestionMarkField>(), 0);
@@ -708,7 +708,7 @@
// still congested, after marking interval cycle
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 6);
lp::Packet pkt5(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt5.count<lp::CongestionMarkField>(), 1);
@@ -725,7 +725,7 @@
// still congested, but within marking interval cycle
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 7);
lp::Packet pkt6(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt6.count<lp::CongestionMarkField>(), 0);
@@ -737,7 +737,7 @@
// still congested, after marking interval cycle
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 8);
lp::Packet pkt7(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt7.count<lp::CongestionMarkField>(), 1);
@@ -752,7 +752,7 @@
// no more congestion
transport->setSendQueueLength(30000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 9);
lp::Packet pkt8(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt8.count<lp::CongestionMarkField>(), 0);
@@ -764,7 +764,7 @@
// send queue congested again, but can't mark packet because within one full interval of last mark
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 10);
lp::Packet pkt9(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt9.count<lp::CongestionMarkField>(), 0);
@@ -782,7 +782,7 @@
BOOST_CHECK_GT(time::steady_clock::now(), nextMarkTime);
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 11);
lp::Packet pkt10(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt10.count<lp::CongestionMarkField>(), 1);
@@ -800,7 +800,7 @@
// not marked since within 100ms window before can mark again
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 12);
lp::Packet pkt11(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt11.count<lp::CongestionMarkField>(), 0);
@@ -813,7 +813,7 @@
// markable packet, queue length still above threshold
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 13);
lp::Packet pkt12(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt12.count<lp::CongestionMarkField>(), 1);
@@ -828,7 +828,7 @@
// no more congestion
transport->setSendQueueLength(10000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 14);
lp::Packet pkt13(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt13.count<lp::CongestionMarkField>(), 0);
@@ -841,7 +841,7 @@
// start congestion again
transport->setSendQueueLength(66000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 15);
lp::Packet pkt14(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt14.count<lp::CongestionMarkField>(), 0);
@@ -852,7 +852,7 @@
// no more congestion, cancel marking interval
transport->setSendQueueLength(5000);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 16);
lp::Packet pkt15(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt15.count<lp::CongestionMarkField>(), 0);
@@ -878,7 +878,7 @@
// no congestion
transport->setSendQueueLength(0);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet pkt1(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt1.count<lp::CongestionMarkField>(), 0);
@@ -888,7 +888,7 @@
// no congestion
transport->setSendQueueLength(65536);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 2);
lp::Packet pkt2(transport->sentPackets.back().packet);
BOOST_CHECK_EQUAL(pkt2.count<lp::CongestionMarkField>(), 0);
@@ -898,7 +898,7 @@
// first congested (not marked yet) packet
transport->setSendQueueLength(65537);
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 3);
lp::Packet pkt3(transport->sentPackets.back().packet);
BOOST_REQUIRE_EQUAL(pkt3.count<lp::CongestionMarkField>(), 0);
@@ -1056,7 +1056,7 @@
auto interest = makeInterest("/12345678");
interest->setTag(make_shared<lp::IncomingFaceIdTag>(1000));
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1074,7 +1074,7 @@
auto interest = makeInterest("/12345678");
interest->setTag(make_shared<lp::IncomingFaceIdTag>(1000));
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1142,7 +1142,7 @@
auto interest = makeInterest("/12345678");
interest->setTag(make_shared<lp::CongestionMarkTag>(1));
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1155,7 +1155,7 @@
auto data = makeData("/12345678");
data->setTag(make_shared<lp::CongestionMarkTag>(0));
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1169,7 +1169,7 @@
lp::NackReason::NO_ROUTE);
nack.setTag(make_shared<lp::CongestionMarkTag>(std::numeric_limits<uint64_t>::max()));
- face->sendNack(nack, 0);
+ face->sendNack(nack);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1232,7 +1232,7 @@
auto interest = makeInterest("/12345678");
interest->setTag(make_shared<lp::NonDiscoveryTag>(lp::EmptyValue{}));
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1248,7 +1248,7 @@
auto interest = makeInterest("/12345678");
interest->setTag(make_shared<lp::NonDiscoveryTag>(lp::EmptyValue{}));
- face->sendInterest(*interest, 0);
+ face->sendInterest(*interest);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1336,7 +1336,7 @@
auto pah = makePrefixAnnHeader("/local/ndn/prefix");
data->setTag(make_shared<lp::PrefixAnnouncementTag>(pah));
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);
@@ -1353,7 +1353,7 @@
auto pah = makePrefixAnnHeader("/local/ndn/prefix");
data->setTag(make_shared<lp::PrefixAnnouncementTag>(pah));
- face->sendData(*data, 0);
+ face->sendData(*data);
BOOST_REQUIRE_EQUAL(transport->sentPackets.size(), 1);
lp::Packet sent(transport->sentPackets.back().packet);