commit b84cc92a8f27745e5c342901cea4f9d03e242bb3
author Alexander Afanasyev <alexander.afanasyev@ucla.edu> Mon Feb 24 17:52:58 2014 -0800
committer Alexander Afanasyev <alexander.afanasyev@ucla.edu> Tue Feb 25 16:51:25 2014 -0800
tree d38b75fd6d0963f258ca999af558072726c733a6
parent dbe7173db1fad7058f6874b2502e59957c07c7d3

core: Initial implementation for run-time selection of log level

Log level can be controlled using NFD_LOG environment variable. The
following options are available

Set up log level using mnemonic

    NFD_LOG=none|error|warn|info|debug|trace

Set up log level using log-level number (0 none, >=5 all)

    NFD_LOG=0|1|2|3|4|5|6|...

Change-Id: Id38c2775f1137a4e38e4896963ab9a01fc863d2c
Refs: #1267

daemon/core/logger.cpp

diff --git a/daemon/core/logger.cpp b/daemon/core/logger.cpp
index 14dd380..928b112 100644
--- a/daemon/core/logger.cpp
+++ b/daemon/core/logger.cpp
@@ -7,14 +7,69 @@
  */
 
 #include "logger.hpp"
+#include <boost/algorithm/string.hpp>
 
-namespace nfd
+namespace nfd {
+
+inline static bool
+isNumber(const std::string& s)
 {
+  if (s.empty())
+    return false;
+
+  for (std::string::const_iterator i = s.begin(); i != s.end(); ++i)
+    {
+      if (!std::isdigit(*i))
+        return false;
+    }
+
+  return true;
+}
 
 Logger::Logger(const std::string& name)
-  : m_moduleName(name),
-    m_isEnabled(true)
+  : m_moduleName(name)
 {
+  char* nfdLog = getenv("NFD_LOG");
+  if (nfdLog)
+    {
+      std::string level = nfdLog;
+      if (isNumber(nfdLog))
+        {
+          setLogLevel(boost::lexical_cast<uint32_t>(nfdLog));
+        }
+      else if (boost::iequals(level, "none"))
+        {
+          m_enabledLogLevel = LOG_NONE;
+        }
+      else if (boost::iequals(level, "error"))
+        {
+          m_enabledLogLevel = LOG_ERROR;
+        }
+      else if (boost::iequals(level, "warn"))
+        {
+          m_enabledLogLevel = LOG_WARN;
+        }
+      else if (boost::iequals(level, "info"))
+        {
+          m_enabledLogLevel = LOG_INFO;
+        }
+      else if (boost::iequals(level, "debug"))
+        {
+          m_enabledLogLevel = LOG_DEBUG;
+        }
+      else if (boost::iequals(level, "trace"))
+        {
+          m_enabledLogLevel = LOG_TRACE;
+        }
+      else
+        {
+          m_enabledLogLevel = LOG_ALL;
+        }
+    }
+  else
+    {
+      m_enabledLogLevel = LOG_WARN;
+    }
 }
 
 std::ostream&

daemon/core/logger.hpp

diff --git a/daemon/core/logger.hpp b/daemon/core/logger.hpp
index f8c6e8e..aad2394 100644
--- a/daemon/core/logger.hpp
+++ b/daemon/core/logger.hpp
@@ -18,22 +18,29 @@
   LOG_NONE           = 0, // no messages
   LOG_ERROR          = 1, // serious error messages
   LOG_WARN           = 2, // warning messages
-  LOG_TRACE          = 3, // trace messages
+  LOG_INFO           = 3, // informational messages
   LOG_DEBUG          = 4, // debug messages
-  LOG_INFO           = 5, // informational messages
-  LOG_FATAL          = 6, // fatal error messages
-  LOG_ALL            = 0x0fffffff, // all messages
+  LOG_TRACE          = 5, // trace messages (most verbose)
+  // LOG_FATAL is not a level and is logged unconditionally
+  LOG_ALL            = 255, // all messages
 };
 
 class Logger
 {
 public:
+  explicit
   Logger(const std::string& name);
   
   bool
   isEnabled(LogLevel level)
   {
-    return m_isEnabled;
+    return (m_enabledLogLevel >= level);
+  }
+
+  void
+  setLogLevel(uint32_t level)
+  {
+    m_enabledLogLevel = static_cast<LogLevel>(level);
   }
   
   const std::string&
@@ -44,7 +51,7 @@
   
 private:
   std::string m_moduleName;
-  bool m_isEnabled;
+  uint32_t    m_enabledLogLevel;
 };
 
 std::ostream&
@@ -93,8 +100,7 @@
        std::cerr<<"ERROR: "<<"["<<g_logger<<"] " << expression <<"\n"
   
 #define NFD_LOG_FATAL(expression)\
-    if(g_logger.isEnabled(nfd::LOG_FATAL)) \
-       std::cerr<<"FATAL: "<<"["<<g_logger<<"] " << expression <<"\n"
+    std::cerr<<"FATAL: "<<"["<<g_logger<<"] " << expression <<"\n"
   
 } //namespace nfd