commit 5fdcbec250db8aa9fab9e2b1102e865f958e9e29
author awlane <awlane@memphis.edu> Fri Dec 15 14:56:05 2023 -0600
committer awlane <awlane@memphis.edu> Mon Feb 05 14:39:48 2024 -0600
tree 3f8ba51d1c0e2ad09fcdc428c17bc6b24e158252
parent 9acba9c5646461b2588dc6be7b4b1bbd1649e501

fw: ASF: Fix implementation not matching technical report

This commit resolves several issues. First, a bug was discovered
regarding the usage of std::set objects when ranking faces for
forwarding and probing purposes. These objects enforce uniqueness;
however, this is defined based on the comparison function provided.
As no fields that were inherently unique were used to rank faces, this
would mean that a face with matching ranking information as one
inserted previously would be blocked from being inserted into face
ranking for forwarding and probing. We add faceId as a tiebreaker to
ensure deterministic behavior in these cases. We also fix an issue
where the count of consecutive silent timeouts was not properly cleared
upon the receipt of data or when a timeout was marked.

Additionally, this commit replaces previous implementations of the
ranking code for forwarding and probing. This is partially in order
to eliminate bugs introduced by incorrect implementations of the ranking
for probing and forwarding, as well as trying to make the code easier
to understand and maintain. This included removing a specific
optimization in probing by including unmeasured faces in the
ranking rather than have probes to unmeasured faces be ordered
based on undefined metrics (in practice, tied faces were inserted
in route creation order). However, we did make the choice to add
cost as a tiebreaker for working measured faces, as was the case
with the initial implementation for forwarding.

Refs #5310

Change-Id: Iabfdafea764fe24fe6c478a6073734e51aaf9fa1