commit 9a090a0f912bb3a31d57370776517f413bac307f
author Davide Pesavento <davide.pesavento@lip6.fr> Thu Jan 29 18:15:26 2015 +0100
committer Davide Pesavento <davide.pesavento@lip6.fr> Fri Jan 30 03:55:23 2015 +0100
tree aa9f58aafc42f446cb433603b96375ccbc9e4dd8
parent 8919abe4c4e6d0616d44aa3e0fd31299993959c7

EthernetFace: report packets dropped by the kernel if debug is enabled

Change-Id: I8b0f9774c4ad785da476aba88f0b6a212256bf51
Refs: #2441

daemon/face/ethernet-face.cpp

diff --git a/daemon/face/ethernet-face.cpp b/daemon/face/ethernet-face.cpp
index d623aa2..4994926 100644
--- a/daemon/face/ethernet-face.cpp
+++ b/daemon/face/ethernet-face.cpp
@@ -75,6 +75,9 @@
   , m_interfaceName(interface.name)
   , m_srcAddress(interface.etherAddress)
   , m_destAddress(address)
+#ifdef _DEBUG
+  , m_nDropped(0)
+#endif
 {
   NFD_LOG_INFO("Creating ethernet face on " << m_interfaceName << ": "
                << m_srcAddress << " <--> " << m_destAddress);
@@ -181,7 +184,8 @@
 
   if (pcap_setdirection(m_pcap.get(), PCAP_D_IN) < 0)
     // no need to throw on failure, BPF will filter unwanted packets anyway
-    NFD_LOG_WARN("pcap_setdirection: " << pcap_geterr(m_pcap.get()));
+    NFD_LOG_WARN("[id:" << getId() << ",endpoint:" << m_interfaceName
+                 << "] pcap_setdirection failed: " << pcap_geterr(m_pcap.get()));
 }
 
 void
@@ -335,6 +339,23 @@
       processIncomingPacket(header, packet);
     }
 
+#ifdef _DEBUG
+  pcap_stat ps{};
+  ret = pcap_stats(m_pcap.get(), &ps);
+  if (ret < 0)
+    {
+      NFD_LOG_DEBUG("[id:" << getId() << ",endpoint:" << m_interfaceName
+                    << "] pcap_stats failed: " << pcap_geterr(m_pcap.get()));
+    }
+  else if (ret == 0)
+    {
+      if (ps.ps_drop - m_nDropped > 0)
+        NFD_LOG_DEBUG("[id:" << getId() << ",endpoint:" << m_interfaceName
+                      << "] Detected " << ps.ps_drop - m_nDropped << " dropped packet(s)");
+      m_nDropped = ps.ps_drop;
+    }
+#endif
+
   m_socket->async_read_some(boost::asio::null_buffers(),
                             bind(&EthernetFace::handleRead, this,
                                  boost::asio::placeholders::error,

daemon/face/ethernet-face.hpp

diff --git a/daemon/face/ethernet-face.hpp b/daemon/face/ethernet-face.hpp
index 7a3d881..cb6303b 100644
--- a/daemon/face/ethernet-face.hpp
+++ b/daemon/face/ethernet-face.hpp
@@ -162,6 +162,11 @@
   unique_ptr<ndnlp::Slicer> m_slicer;
   std::unordered_map<ethernet::Address, Reassembler> m_reassemblers;
   static const time::nanoseconds REASSEMBLER_LIFETIME;
+
+#ifdef _DEBUG
+  /// number of packets dropped by the kernel, as reported by libpcap
+  unsigned int m_nDropped;
+#endif
 };
 
 } // namespace nfd