commit 811c0100987d4de38ca52a0b9236ef3ba41e68e0
author Junxiao Shi <git@mail1.yoursunny.com> Wed Aug 10 04:12:45 2016 +0000
committer Junxiao Shi <git@mail1.yoursunny.com> Wed Aug 10 04:12:45 2016 +0000
tree 2a1daa5a164fdc42e9113267d0e63561a2a1a9e2
parent 67f30273dd61b3b628f8fbaa16ba95890e741dda

table: NameTree findExactMatch, findLongestPrefixMatch return Entry*

refs #3687

Change-Id: I32752fd711b9641228fbb7f356e72144780cf9ec

tests/daemon/table/name-tree.t.cpp

diff --git a/tests/daemon/table/name-tree.t.cpp b/tests/daemon/table/name-tree.t.cpp
index 4c030ac..b5d37d0 100644
--- a/tests/daemon/table/name-tree.t.cpp
+++ b/tests/daemon/table/name-tree.t.cpp
@@ -263,24 +263,24 @@
 
   // validate lookup() and findExactMatch()
 
-  Name nameAB ("/a/b");
-  BOOST_CHECK_EQUAL(npeABC->getParent(), nt.findExactMatch(nameAB).get());
-  BOOST_CHECK_EQUAL(npeABD->getParent(), nt.findExactMatch(nameAB).get());
+  Name nameAB("/a/b");
+  BOOST_CHECK_EQUAL(npeABC->getParent(), nt.findExactMatch(nameAB));
+  BOOST_CHECK_EQUAL(npeABD->getParent(), nt.findExactMatch(nameAB));
 
   Name nameA ("/a");
-  BOOST_CHECK_EQUAL(npeAE->getParent(), nt.findExactMatch(nameA).get());
+  BOOST_CHECK_EQUAL(npeAE->getParent(), nt.findExactMatch(nameA));
 
   Name nameRoot ("/");
-  BOOST_CHECK_EQUAL(npeF->getParent(), nt.findExactMatch(nameRoot).get());
+  BOOST_CHECK_EQUAL(npeF->getParent(), nt.findExactMatch(nameRoot));
   BOOST_CHECK_EQUAL(nt.size(), 7);
 
   Name name0("/does/not/exist");
-  shared_ptr<Entry> npe0 = nt.findExactMatch(name0);
+  Entry* npe0 = nt.findExactMatch(name0);
   BOOST_CHECK(npe0 == nullptr);
 
 
   // Longest Prefix Matching
-  shared_ptr<Entry> temp;
+  Entry* temp = nullptr;
   Name nameABCLPM("/a/b/c/def/asdf/nlf");
   temp = nt.findLongestPrefixMatch(nameABCLPM);
   BOOST_CHECK_EQUAL(temp, nt.findExactMatch(nameABC));
@@ -312,7 +312,7 @@
   bool eraseResult = false;
   temp = nt.findExactMatch(nameABC);
   if (temp != nullptr)
-    eraseResult = nt.eraseIfEmpty(temp.get());
+    eraseResult = nt.eraseIfEmpty(temp);
   BOOST_CHECK_EQUAL(nt.size(), 6);
   BOOST_CHECK(nt.findExactMatch(nameABC) == nullptr);
   BOOST_CHECK_EQUAL(eraseResult, true);
@@ -320,7 +320,7 @@
   eraseResult = false;
   temp = nt.findExactMatch(nameABCLPM);
   if (temp != nullptr)
-    eraseResult = nt.eraseIfEmpty(temp.get());
+    eraseResult = nt.eraseIfEmpty(temp);
   BOOST_CHECK(temp == nullptr);
   BOOST_CHECK_EQUAL(nt.size(), 6);
   BOOST_CHECK_EQUAL(eraseResult, false);
@@ -331,7 +331,7 @@
   eraseResult = false;
   temp = nt.findExactMatch(nameABC);
   if (temp != nullptr)
-    eraseResult = nt.eraseIfEmpty(temp.get());
+    eraseResult = nt.eraseIfEmpty(temp);
   BOOST_CHECK_EQUAL(nt.size(), 6);
   BOOST_CHECK_EQUAL(eraseResult, true);
   BOOST_CHECK(nt.findExactMatch(nameABC) == nullptr);
@@ -349,14 +349,14 @@
   // try to erase /a/b/c, should return false
   temp = nt.findExactMatch(nameABC);
   BOOST_CHECK_EQUAL(temp->getName(), nameABC);
-  eraseResult = nt.eraseIfEmpty(temp.get());
+  eraseResult = nt.eraseIfEmpty(temp);
   BOOST_CHECK_EQUAL(eraseResult, false);
   temp = nt.findExactMatch(nameABC);
   BOOST_CHECK_EQUAL(temp->getName(), nameABC);
 
   temp = nt.findExactMatch(nameABD);
   if (temp != nullptr)
-    nt.eraseIfEmpty(temp.get());
+    nt.eraseIfEmpty(temp);
   BOOST_CHECK_EQUAL(nt.size(), 8);
 }
 
@@ -587,7 +587,7 @@
   nt.lookup("/F");
 
   auto&& enumerable = nt.partialEnumerate("/A",
-    [] (const Entry& entry) -> std::pair<bool, bool> {
+    [] (const Entry& entry) {
       bool visitEntry = false;
       bool visitChildren = false;
 
@@ -601,7 +601,7 @@
         visitChildren = true;
       }
 
-      return {visitEntry, visitChildren};
+      return std::make_pair(visitEntry, visitChildren);
     });
 
   EnumerationVerifier(enumerable)
@@ -688,7 +688,7 @@
   for (NameTree::const_iterator it = nt.begin(); it != nt.end(); ++it) {
     BOOST_CHECK(seenNames.insert(it->getName()).second);
     if (it->getName() == nameD) {
-      nt.eraseIfEmpty(nt.findExactMatch("/A/F/G").get()); // /A/F/G and /A/F are erased
+      nt.eraseIfEmpty(nt.findExactMatch("/A/F/G")); // /A/F/G and /A/F are erased
     }
   }