core: make SizeCounter use pointer instead of reference
Restore virtual inheritance of GenericLinkServiceCounters in
GenericLinkService
refs #3941
Change-Id: I368e4694fee7bc97173fddfc81d0c679da0d6eed
diff --git a/daemon/face/generic-link-service.hpp b/daemon/face/generic-link-service.hpp
index 8a8622f..4c347d6 100644
--- a/daemon/face/generic-link-service.hpp
+++ b/daemon/face/generic-link-service.hpp
@@ -41,9 +41,6 @@
class GenericLinkServiceCounters : public virtual LinkService::Counters
{
public:
- explicit
- GenericLinkServiceCounters(const LpReassembler& reassembler);
-
/** \brief count of failed fragmentations
*/
PacketCounter nFragmentationErrors;
@@ -87,10 +84,9 @@
/** \brief GenericLinkService is a LinkService that implements the NDNLPv2 protocol
* \sa https://redmine.named-data.net/projects/nfd/wiki/NDNLPv2
- * \todo #3941 declare GenericLinkServiceCounters as virtual inheritance
*/
class GenericLinkService : public LinkService
- , protected GenericLinkServiceCounters
+ , protected virtual GenericLinkServiceCounters
{
public:
/** \brief Options that control the behavior of GenericLinkService