fw: make strategies understand scope
refs #1253
Change-Id: I57f7a6008e6f08c9817e58f480020eb9219a4aec
diff --git a/tests/fw/broadcast-strategy.cpp b/tests/fw/broadcast-strategy.cpp
index b256432..9c69c10 100644
--- a/tests/fw/broadcast-strategy.cpp
+++ b/tests/fw/broadcast-strategy.cpp
@@ -15,7 +15,7 @@
BOOST_FIXTURE_TEST_SUITE(FwBroadcastStrategy, BaseFixture)
-BOOST_AUTO_TEST_CASE(ForwardTwo)
+BOOST_AUTO_TEST_CASE(Forward2)
{
Forwarder forwarder;
typedef StrategyTester<fw::BroadcastStrategy> BroadcastStrategyTester;
@@ -29,18 +29,17 @@
forwarder.addFace(face3);
Fib& fib = forwarder.getFib();
- std::pair<shared_ptr<fib::Entry>, bool> fibInsertResult = fib.insert(Name());
- shared_ptr<fib::Entry> fibEntry = fibInsertResult.first;
+ shared_ptr<fib::Entry> fibEntry = fib.insert(Name()).first;
fibEntry->addNextHop(face1, 0);
fibEntry->addNextHop(face2, 0);
fibEntry->addNextHop(face3, 0);
- Interest interest(Name("ndn:/H0D6i5fc"));
+ shared_ptr<Interest> interest = makeInterest("ndn:/H0D6i5fc");
Pit& pit = forwarder.getPit();
- std::pair<shared_ptr<pit::Entry>, bool> pitInsertResult = pit.insert(interest);
- shared_ptr<pit::Entry> pitEntry = pitInsertResult.first;
+ shared_ptr<pit::Entry> pitEntry = pit.insert(*interest).first;
+ pitEntry->insertOrUpdateInRecord(face3, *interest);
- strategy.afterReceiveInterest(*face3, interest, fibEntry, pitEntry);
+ strategy.afterReceiveInterest(*face3, *interest, fibEntry, pitEntry);
BOOST_CHECK_EQUAL(strategy.m_rejectPendingInterestHistory.size(), 0);
BOOST_CHECK_EQUAL(strategy.m_sendInterestHistory.size(), 2);
bool hasFace1 = false;
@@ -58,7 +57,32 @@
BOOST_CHECK(hasFace1 && hasFace2);
}
-BOOST_AUTO_TEST_CASE(Reject)
+BOOST_AUTO_TEST_CASE(RejectScope)
+{
+ Forwarder forwarder;
+ typedef StrategyTester<fw::BroadcastStrategy> BroadcastStrategyTester;
+ BroadcastStrategyTester strategy(forwarder);
+
+ shared_ptr<DummyFace> face1 = make_shared<DummyFace>();
+ shared_ptr<DummyFace> face2 = make_shared<DummyFace>();
+ forwarder.addFace(face1);
+ forwarder.addFace(face2);
+
+ Fib& fib = forwarder.getFib();
+ shared_ptr<fib::Entry> fibEntry = fib.insert("ndn:/localhop/uS09bub6tm").first;
+ fibEntry->addNextHop(face2, 0);
+
+ shared_ptr<Interest> interest = makeInterest("ndn:/localhop/uS09bub6tm/eG3MMoP6z");
+ Pit& pit = forwarder.getPit();
+ shared_ptr<pit::Entry> pitEntry = pit.insert(*interest).first;
+ pitEntry->insertOrUpdateInRecord(face1, *interest);
+
+ strategy.afterReceiveInterest(*face1, *interest, fibEntry, pitEntry);
+ BOOST_CHECK_EQUAL(strategy.m_rejectPendingInterestHistory.size(), 1);
+ BOOST_CHECK_EQUAL(strategy.m_sendInterestHistory.size(), 0);
+}
+
+BOOST_AUTO_TEST_CASE(RejectLoopback)
{
Forwarder forwarder;
typedef StrategyTester<fw::BroadcastStrategy> BroadcastStrategyTester;
@@ -68,16 +92,15 @@
forwarder.addFace(face1);
Fib& fib = forwarder.getFib();
- std::pair<shared_ptr<fib::Entry>, bool> fibInsertResult = fib.insert(Name());
- shared_ptr<fib::Entry> fibEntry = fibInsertResult.first;
+ shared_ptr<fib::Entry> fibEntry = fib.insert(Name()).first;
fibEntry->addNextHop(face1, 0);
- Interest interest(Name("ndn:/H0D6i5fc"));
+ shared_ptr<Interest> interest = makeInterest("ndn:/H0D6i5fc");
Pit& pit = forwarder.getPit();
- std::pair<shared_ptr<pit::Entry>, bool> pitInsertResult = pit.insert(interest);
- shared_ptr<pit::Entry> pitEntry = pitInsertResult.first;
+ shared_ptr<pit::Entry> pitEntry = pit.insert(*interest).first;
+ pitEntry->insertOrUpdateInRecord(face1, *interest);
- strategy.afterReceiveInterest(*face1, interest, fibEntry, pitEntry);
+ strategy.afterReceiveInterest(*face1, *interest, fibEntry, pitEntry);
BOOST_CHECK_EQUAL(strategy.m_rejectPendingInterestHistory.size(), 1);
BOOST_CHECK_EQUAL(strategy.m_sendInterestHistory.size(), 0);
}
diff --git a/tests/fw/client-control-strategy.cpp b/tests/fw/client-control-strategy.cpp
index 42af192..aab5baa 100644
--- a/tests/fw/client-control-strategy.cpp
+++ b/tests/fw/client-control-strategy.cpp
@@ -38,9 +38,10 @@
Pit& pit = forwarder.getPit();
// Interest with valid NextHopFaceId
- shared_ptr<Interest> interest1 = make_shared<Interest>("ndn:/0z8r6yDDe");
+ shared_ptr<Interest> interest1 = makeInterest("ndn:/0z8r6yDDe");
interest1->setNextHopFaceId(face1->getId());
shared_ptr<pit::Entry> pitEntry1 = pit.insert(*interest1).first;
+ pitEntry1->insertOrUpdateInRecord(face4, *interest1);
strategy.m_sendInterestHistory.clear();
strategy.afterReceiveInterest(*face4, *interest1, fibEntry, pitEntry1);
@@ -48,8 +49,9 @@
BOOST_CHECK_EQUAL(strategy.m_sendInterestHistory[0].get<1>(), face1);
// Interest without NextHopFaceId
- shared_ptr<Interest> interest2 = make_shared<Interest>("ndn:/y6JQADGVz");
+ shared_ptr<Interest> interest2 = makeInterest("ndn:/y6JQADGVz");
shared_ptr<pit::Entry> pitEntry2 = pit.insert(*interest2).first;
+ pitEntry2->insertOrUpdateInRecord(face4, *interest2);
strategy.m_sendInterestHistory.clear();
strategy.afterReceiveInterest(*face4, *interest2, fibEntry, pitEntry2);
@@ -57,9 +59,10 @@
BOOST_CHECK_EQUAL(strategy.m_sendInterestHistory[0].get<1>(), face2);
// Interest with invalid NextHopFaceId
- shared_ptr<Interest> interest3 = make_shared<Interest>("ndn:/0z8r6yDDe");
+ shared_ptr<Interest> interest3 = makeInterest("ndn:/0z8r6yDDe");
interest3->setNextHopFaceId(face3->getId());
shared_ptr<pit::Entry> pitEntry3 = pit.insert(*interest3).first;
+ pitEntry3->insertOrUpdateInRecord(face4, *interest3);
forwarder.removeFace(face3); // face3 is removed and its FaceId becomes invalid
strategy.m_sendInterestHistory.clear();
diff --git a/tests/table/pit.cpp b/tests/table/pit.cpp
index 393c1bc..bf1e073 100644
--- a/tests/table/pit.cpp
+++ b/tests/table/pit.cpp
@@ -32,9 +32,9 @@
shared_ptr<Interest> interest4 = makeInterest(name);
interest4->setInterestLifetime(static_cast<ndn::Milliseconds>(8795));
interest4->setNonce(17365);
-
+
pit::Entry entry(*interest);
-
+
BOOST_CHECK_EQUAL(entry.getInterest().getName(), name);
BOOST_CHECK_EQUAL(entry.getName(), name);
@@ -42,7 +42,7 @@
BOOST_CHECK_EQUAL(inRecords1.size(), 0);
const pit::OutRecordCollection& outRecords1 = entry.getOutRecords();
BOOST_CHECK_EQUAL(outRecords1.size(), 0);
-
+
// insert InRecord
time::Point before1 = time::now();
pit::InRecordCollection::iterator in1 =
@@ -58,7 +58,7 @@
BOOST_CHECK_LE(std::abs(in1->getExpiry() - in1->getLastRenewed()
- time::milliseconds(interest1->getInterestLifetime())),
(after1 - before1));
-
+
// insert OutRecord
time::Point before2 = time::now();
pit::OutRecordCollection::iterator out1 =
@@ -74,7 +74,7 @@
BOOST_CHECK_LE(std::abs(out1->getExpiry() - out1->getLastRenewed()
- time::milliseconds(interest1->getInterestLifetime())),
(after2 - before2));
-
+
// update InRecord
time::Point before3 = time::now();
pit::InRecordCollection::iterator in2 =
@@ -95,7 +95,7 @@
const pit::InRecordCollection& inRecords4 = entry.getInRecords();
BOOST_CHECK_EQUAL(inRecords4.size(), 2);
BOOST_CHECK_EQUAL(in3->getFace(), face2);
-
+
// delete all InRecords
entry.deleteInRecords();
const pit::InRecordCollection& inRecords5 = entry.getInRecords();
@@ -107,28 +107,62 @@
const pit::OutRecordCollection& outRecords3 = entry.getOutRecords();
BOOST_CHECK_EQUAL(outRecords3.size(), 2);
BOOST_CHECK_EQUAL(out2->getFace(), face2);
-
+
// delete OutRecord
entry.deleteOutRecord(face2);
const pit::OutRecordCollection& outRecords4 = entry.getOutRecords();
BOOST_REQUIRE_EQUAL(outRecords4.size(), 1);
BOOST_CHECK_EQUAL(outRecords4.begin()->getFace(), face1);
-
}
BOOST_AUTO_TEST_CASE(EntryNonce)
{
- Name name("ndn:/qtCQ7I1c");
- Interest interest(name);
-
- pit::Entry entry(interest);
-
+ shared_ptr<Interest> interest = makeInterest("ndn:/qtCQ7I1c");
+
+ pit::Entry entry(*interest);
+
BOOST_CHECK_EQUAL(entry.addNonce(25559), true);
BOOST_CHECK_EQUAL(entry.addNonce(25559), false);
BOOST_CHECK_EQUAL(entry.addNonce(19004), true);
BOOST_CHECK_EQUAL(entry.addNonce(19004), false);
}
+BOOST_AUTO_TEST_CASE(EntryLifetime)
+{
+ shared_ptr<Interest> interest = makeInterest("ndn:/7oIEurbgy6");
+ BOOST_ASSERT(interest->getInterestLifetime() < 0); // library uses -1 to indicate unset lifetime
+
+ shared_ptr<Face> face = make_shared<DummyFace>();
+ pit::Entry entry(*interest);
+
+ pit::InRecordCollection::iterator inIt = entry.insertOrUpdateInRecord(face, *interest);
+ BOOST_CHECK_GT(inIt->getExpiry(), time::now());
+
+ pit::OutRecordCollection::iterator outIt = entry.insertOrUpdateOutRecord(face, *interest);
+ BOOST_CHECK_GT(outIt->getExpiry(), time::now());
+}
+
+BOOST_AUTO_TEST_CASE(EntryCanForwardTo)
+{
+ shared_ptr<Interest> interest = makeInterest("ndn:/WDsuBLIMG");
+ pit::Entry entry(*interest);
+
+ shared_ptr<Face> face1 = make_shared<DummyFace>();
+ shared_ptr<Face> face2 = make_shared<DummyFace>();
+
+ entry.insertOrUpdateInRecord(face1, *interest);
+ BOOST_CHECK_EQUAL(entry.canForwardTo(*face1), false);
+ BOOST_CHECK_EQUAL(entry.canForwardTo(*face2), true);
+
+ entry.insertOrUpdateInRecord(face2, *interest);
+ BOOST_CHECK_EQUAL(entry.canForwardTo(*face1), true);
+ BOOST_CHECK_EQUAL(entry.canForwardTo(*face2), true);
+
+ entry.insertOrUpdateOutRecord(face1, *interest);
+ BOOST_CHECK_EQUAL(entry.canForwardTo(*face1), false);
+ BOOST_CHECK_EQUAL(entry.canForwardTo(*face2), true);
+}
+
BOOST_AUTO_TEST_CASE(Insert)
{
Name name1("ndn:/5vzBNnMst");
@@ -161,12 +195,12 @@
Interest interestJ(name1, -1, -1, exclude0, -1, false, -1, -1.0, 2192);
// different Name+exclude1
Interest interestK(name2, -1, -1, exclude1, -1, false, -1, -1.0, 0);
-
+
NameTree nameTree(16);
Pit pit(nameTree);
std::pair<shared_ptr<pit::Entry>, bool> insertResult;
-
+
BOOST_CHECK_EQUAL(pit.size(), 0);
insertResult = pit.insert(interestA);
@@ -176,28 +210,28 @@
insertResult = pit.insert(interestB);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 2);
-
+
insertResult = pit.insert(interestC);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 3);
-
+
insertResult = pit.insert(interestD);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 4);
-
+
insertResult = pit.insert(interestE);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 5);
-
+
insertResult = pit.insert(interestF);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 6);
-
+
insertResult = pit.insert(interestG);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 7);
-
+
insertResult = pit.insert(interestH);
BOOST_CHECK_EQUAL(insertResult.second, false);// only guiders differ
BOOST_CHECK_EQUAL(pit.size(), 7);
@@ -205,11 +239,11 @@
insertResult = pit.insert(interestI);
BOOST_CHECK_EQUAL(insertResult.second, false);// only guiders differ
BOOST_CHECK_EQUAL(pit.size(), 7);
-
+
insertResult = pit.insert(interestJ);
BOOST_CHECK_EQUAL(insertResult.second, false);// only guiders differ
BOOST_CHECK_EQUAL(pit.size(), 7);
-
+
insertResult = pit.insert(interestK);
BOOST_CHECK_EQUAL(insertResult.second, true);
BOOST_CHECK_EQUAL(pit.size(), 8);
@@ -223,7 +257,7 @@
Pit pit(nameTree);
std::pair<shared_ptr<pit::Entry>, bool> insertResult;
-
+
BOOST_CHECK_EQUAL(pit.size(), 0);
insertResult = pit.insert(interest);
@@ -233,7 +267,7 @@
insertResult = pit.insert(interest);
BOOST_CHECK_EQUAL(insertResult.second, false);
BOOST_CHECK_EQUAL(pit.size(), 1);
-
+
pit.erase(insertResult.first);
BOOST_CHECK_EQUAL(pit.size(), 0);
@@ -258,7 +292,7 @@
NameTree nameTree(16);
Pit pit(nameTree);
int count = 0;
-
+
BOOST_CHECK_EQUAL(pit.size(), 0);
pit.insert(interestA );
@@ -266,13 +300,13 @@
pit.insert(interestD );
nameTree.lookup(nameABCD); // make sure /A/B/C/D is in nameTree
-
+
BOOST_CHECK_EQUAL(pit.size(), 3);
Data data(nameABCD);
-
+
shared_ptr<pit::DataMatchResult> matches = pit.findAllDataMatches(data);
-
+
bool hasA = false;
bool hasAB = false;
bool hasABC = false;
@@ -288,10 +322,10 @@
if (entry->getName().equals(nameAB))
hasAB = true;
-
+
if (entry->getName().equals(nameABC))
hasABC = true;
-
+
if (entry->getName().equals(nameD))
hasD = true;
}