commit 3db9807200aafca152ae51563c0f8c98b5cffd6b
author Davide Pesavento <davidepesa@gmail.com> Tue Mar 09 23:03:27 2021 -0500
committer Davide Pesavento <davidepesa@gmail.com> Mon Mar 15 18:15:01 2021 -0400
tree 6deec262bcdd9a3e821cfc3b6e954ef805b14d6b
parent 03a75f6c8849036f57781b18889c5f944f77307e

daemon: mark some classes and methods 'final'

As suggested by gcc's -Wsuggest-final-types and -Wsuggest-final-methods

Change-Id: I1622857ee53581efd0c6ce3fe93199c72202d817

tests/daemon/mgmt/tables-config-section.t.cpp

diff --git a/tests/daemon/mgmt/tables-config-section.t.cpp b/tests/daemon/mgmt/tables-config-section.t.cpp
index 789d64f..3f77a1d 100644
--- a/tests/daemon/mgmt/tables-config-section.t.cpp
+++ b/tests/daemon/mgmt/tables-config-section.t.cpp
@@ -206,13 +206,9 @@
 class CsUnsolicitedPolicyFixture : public TablesConfigSectionFixture
 {
 protected:
-  class DummyUnsolicitedDataPolicy : public fw::AdmitNetworkUnsolicitedDataPolicy
-  {
-  };
-
   CsUnsolicitedPolicyFixture()
   {
-    forwarder.setUnsolicitedDataPolicy(make_unique<DummyUnsolicitedDataPolicy>());
+    forwarder.setUnsolicitedDataPolicy(make_unique<fw::AdmitNetworkUnsolicitedDataPolicy>());
   }
 };
 
@@ -222,7 +218,7 @@
 {
   tablesConfig.ensureConfigured();
 
-  fw::UnsolicitedDataPolicy* currentPolicy = &forwarder.getUnsolicitedDataPolicy();
+  auto* currentPolicy = &forwarder.getUnsolicitedDataPolicy();
   NFD_CHECK_TYPEID_EQUAL(*currentPolicy, fw::DefaultUnsolicitedDataPolicy);
 }
 
@@ -235,7 +231,7 @@
   )CONFIG";
 
   BOOST_REQUIRE_NO_THROW(runConfig(CONFIG, true));
-  fw::UnsolicitedDataPolicy* currentPolicy = &forwarder.getUnsolicitedDataPolicy();
+  auto* currentPolicy = &forwarder.getUnsolicitedDataPolicy();
   NFD_CHECK_TYPEID_NE(*currentPolicy, fw::DefaultUnsolicitedDataPolicy);
 
   BOOST_REQUIRE_NO_THROW(runConfig(CONFIG, false));
@@ -253,7 +249,7 @@
   )CONFIG";
 
   BOOST_REQUIRE_NO_THROW(runConfig(CONFIG, true));
-  fw::UnsolicitedDataPolicy* currentPolicy = &forwarder.getUnsolicitedDataPolicy();
+  auto* currentPolicy = &forwarder.getUnsolicitedDataPolicy();
   NFD_CHECK_TYPEID_NE(*currentPolicy, fw::AdmitAllUnsolicitedDataPolicy);
 
   BOOST_REQUIRE_NO_THROW(runConfig(CONFIG, false));