suppress sparkle error about CFBundleIdentifier
sparkle seems to be checking the remote server
could do test tmr
Change-Id: Iebaca35f41e66964780124979637b17a67ddeb78
diff --git a/gui/chronosharegui.cpp b/gui/chronosharegui.cpp
index a829099..40533c2 100644
--- a/gui/chronosharegui.cpp
+++ b/gui/chronosharegui.cpp
@@ -51,7 +51,7 @@
, m_executor (1)
#endif
#ifdef SPARKLE_SUPPORTED
- , m_autoUpdate(new SparkleAutoUpdate(tr("http://no-url.org")))
+ , m_autoUpdate(new SparkleAutoUpdate(tr("http://irl.cs.ucla.edu")))
#endif
{
setWindowTitle("Settings");
@@ -273,6 +273,8 @@
m_trayIconMenu->addAction(m_viewSettings);
m_trayIconMenu->addAction(m_changeFolder);
m_trayIconMenu->addSeparator();
+ m_trayIconMenu->addAction(m_checkForUpdates);
+ m_trayIconMenu->addSeparator();
m_trayIconMenu->addAction(m_wifiAction);
m_trayIconMenu->addSeparator();
m_trayIconMenu->addAction(m_quitProgram);
@@ -332,7 +334,9 @@
ChronoShareGui::onCheckForUpdates()
{
#ifdef SPARKLE_SUPPORTED
+ cout << "+++++++++++ trying to update +++++++ " << endl;
m_autoUpdate->checkForUpdates();
+ cout << "+++++++++++ end trying to update +++++++ " << endl;
#endif
}
diff --git a/osx/auto-update/sparkle-auto-update.mm b/osx/auto-update/sparkle-auto-update.mm
index 5b35a76..9429892 100644
--- a/osx/auto-update/sparkle-auto-update.mm
+++ b/osx/auto-update/sparkle-auto-update.mm
@@ -22,6 +22,7 @@
#include "sparkle-auto-update.h"
#import <Foundation/Foundation.h>
#import <Sparkle/Sparkle.h>
+#include <stdio.h>
class SparkleAutoUpdate::Private
{
@@ -32,14 +33,15 @@
SparkleAutoUpdate::SparkleAutoUpdate(const QString &updateUrl)
{
d = new Private;
- d->updater = [SUUpdater sharedUpdater];
- [d->updater setAutomaticallyChecksForUpdates:YES];
+ d->updater = [[SUUpdater sharedUpdater] retain];
+ // [d->updater setAutomaticallyChecksForUpdates:YES];
NSURL *url = [NSURL URLWithString: [NSString stringWithUTF8String: updateUrl.toUtf8().data()]];
[d->updater setFeedURL: url];
}
SparkleAutoUpdate::~SparkleAutoUpdate()
{
+ [d->updater release];
delete d;
// presummably SUUpdater handles garbage collection
}
@@ -47,4 +49,5 @@
void SparkleAutoUpdate::checkForUpdates()
{
[d->updater checkForUpdatesInBackground];
+ printf("++++++++ checking update ++++++\n");
}
diff --git a/wscript b/wscript
index b9b9410..2c30e6c 100644
--- a/wscript
+++ b/wscript
@@ -219,6 +219,8 @@
<string>APPL</string>
<key>CFBundleGetInfoString</key>
<string>Created by Waf</string>
+ <key>CFBundleIdentifier</key>
+ <string>edu.ucla.cs.irl.Chronoshare</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>NOTE</key>